Index: page.html
===================================================================
--- page.html	(Revision 14749)
+++ page.html	(Arbeitskopie)
@@ -9,6 +9,7 @@
  tal:attributes="content string:text/html;; charset=${request/client/charset}" />
 <script tal:replace="structure request/base_javascript">
 </script>
+<metal:script define-slot="more_javascript"/>

 </head>
 <body class="body">
@@ -151,12 +152,9 @@
 </html>
 </tal:block>

-<th metal:define-macro="th_label">
+<th metal:define-macro="th_label" tal:attributes="class python:(name in required) and 'required' or ''">
   <label for="any_field" tal:attributes="for name" tal:content="label" i18n:translate="">Text</label>
 </th>
-<th metal:define-macro="th_label_required" class="required">
-  <label for="any_field" tal:attributes="for name" tal:content="label" i18n:translate="">Text</label>
-</th>
 <!--
 The following macros are intended to be used in search pages.

Index: help_controls.js
===================================================================
--- help_controls.js	(Revision 14748)
+++ help_controls.js	(Arbeitskopie)
@@ -5,6 +5,49 @@
 // Some browsers (ok, IE) don't define the "undefined" variable.
 undefined = document.geez_IE_is_really_friggin_annoying;

+/**
+ * example: <form onSubmit="return checkRequiredFields('title', 'priority')">
+ * calls submit_once if everything is ok
+ */
+function checkRequiredFields(fields)
+{
+    var bonk='';
+    var res='';
+    var argv = checkRequiredFields.arguments;
+    var argc = argv.length;
+    var input = '';
+    var val='';
+    var form = document.itemSynopsis
+
+    for (var i=0; i < argc; i++) {
+        fi = argv[i];
+        input = form[fi]
+        if (input) {
+            val = input.value
+            if (val == '' || val == '-1' || val == -1) {
+                if (res == '') {
+                    res = fi;
+                    bonk = input;
+                } else {
+                    res += ', '+fi;
+                }
+            }
+        } else {
+            alert('Couldn\'t find a field '+fi+'!')
+        }
+    }
+    if (res == '') {
+        return submit_once();
+    } else {
+	alert('Please enter a value here ('+res+')')
+        if (window.event && window.event.returnvalue) {
+            event.returnValue = 0;    // work-around for IE
+        }
+        bonk.focus();
+        return false;
+    }
+}
+
 function trim(value) {
   var temp = value;
   var obj = /^(\s*)([\W\w]*)(\b\s*$)/;
@@ -121,3 +164,108 @@
     }
 }

Index: issue.item.html
===================================================================
--- issue.item.html	(Revision 14749)
+++ issue.item.html	(Arbeitskopie)
@@ -23,6 +23,9 @@
   replace="context/id" i18n:name="id" /> Editing</span>
 </tal:block>

+<script type="text/javascript" src="@@file/help_controls.js"
+metal:fill-slot="more_javascript"></script>
+
 <td class="content" metal:fill-slot="content">

 <p tal:condition="not:context/is_view_ok" i18n:translate="">You are not
@@ -31,22 +34,22 @@
 <div tal:condition="context/is_view_ok">

 <form method="POST" name="itemSynopsis"
-      onSubmit="return submit_once()" enctype="multipart/form-data"
-      tal:attributes="action context/designator">
+      tal:define="required python:'title priority'.split()"
+      onSubmit="return ..." enctype="multipart/form-data"
+      tal:attributes="action context/designator;
+onSubmit python:'return checkRequiredFields(\'%s\')'%'\',\''.join(required)">

 <table class="form" tal:define="
-   th_label          templates/page/macros/th_label;
-   th_label_required templates/page/macros/th_label_required;"
->
+   th_label templates/page/macros/th_label;
+">
 <tr tal:define="name string:title; label string:Title">
- <th metal:use-macro="th_label_required"
-  >Title</th>
+ <th metal:use-macro="th_label">Title</th>
  <td colspan=3 tal:content="structure python:context.title.field(size=60)">title</td>
 </tr>

 <tr>
  <tal:set define="name string:priority; label string:Priority">
- <th metal:use-macro="th_label_required">Priority</th>
+ <th metal:use-macro="th_label">Priority</th>
  <td tal:content="structure context/priority/menu">priority</td>
  </tal:set>
  <tal:set define="name string:status; label string:Status">
@@ -56,7 +59,8 @@
 </tr>

 <tr>
- <th i18n:translate="">Superseder</th>
+ <tal:x define="name string:superseder;label string:Superseder">
+ <th metal:use-macro="th_label">Superseder</th>
  <td>
   <span tal:replace="structure python:context.superseder.field(showid=1, size=20)" />
   <span tal:condition="context/is_edit_ok" tal:replace="structure python:db.issue.classhelp('id,title', property='superseder')" />
@@ -67,42 +71,51 @@
         tal:attributes="href string:issue${sup/id}"></a>
   </span>
  </td>
- <th i18n:translate="">Nosy List</th>
+ </tal:x>
+ <tal:x define="name string:nosy; label string:Nosy List">
+ <th metal:use-macro="th_label">Nosy List</th>
  <td>
   <span tal:replace="structure context/nosy/field" />
   <span tal:condition="context/is_edit_ok" tal:replace="structure
 python:db.user.classhelp('username,realname,address', property='nosy', width='600')" /><br>
  </td>
+ </tal:x>
 </tr>

 <tr>
- <th i18n:translate="">Assigned To</th>
+ <tal:x define="name string:assignedto; label string:Assigned To">
+ <th metal:use-macro="th_label">Assigned To</th>
  <td tal:content="structure context/assignedto/menu">assignedto menu</td>
- <th i18n:translate="">Topics</th>
+ </tal:x>
+ <tal:x define="name string:topic; label string:Topics">
+ <th metal:use-macro="th_label">Topics</th>
  <td>
   <span tal:replace="structure context/topic/field" />
   <span tal:condition="context/is_edit_ok" tal:replace="structure python:db.keyword.classhelp(property='topic')" />
  </td>
+ </tal:x>
 </tr>

-<tr tal:condition="context/is_edit_ok">
- <th i18n:translate="">Change Note</th>
+<tr tal:condition="context/is_edit_ok"
+    tal:define="name string:note; label string:Change Note">
+ <th metal:use-macro="th_label">Change Note</th>
  <td colspan=3>
   <textarea tal:content="request/form/@note/value | default"
-            name="@note" wrap="hard" rows="5" cols="80"></textarea>
+            name="@note" wrap="hard" rows="5" cols="80" id="note"></textarea>
  </td>
 </tr>

-<tr tal:condition="context/is_edit_ok">
- <th i18n:translate="">File</th>
- <td colspan=3><input type="file" name="@file" size="40"></td>
+<tr tal:condition="context/is_edit_ok"
+    tal:define="name string:file; label string:File">
+ <th metal:use-macro="th_label">File</th>
+ <td colspan=3><input type="file" name="@file" id="file" size="40"></td>
 </tr>

 <tr tal:condition="context/is_edit_ok">
  <td>
   &nbsp;
   <input type="hidden" name="@template" value="item">
-  <input type="hidden" name="@required" value="title,priority">
+  <input type="hidden" name="@required" value="title,priority" tal:attributes="value python:','.join(required)">
  </td>
  <td colspan=3>
   <span tal:replace="structure context/submit">submit button</span>

 	  	 
