Roundup Tracker - Issues

Issue 2109308

classification
Allow subject of nosy messages be changed from reactor
Type: rfe Severity: normal
Components: Mail interface, Infrastructure Versions:
process
Status: closed fixed
:
: rouilj : fniessink, rouilj
Priority: normal : patch

Created on 2008-09-13 19:32 by fniessink, last changed 2016-06-11 22:08 by rouilj.

Files
File name Uploaded Description Edit Remove
configurable_subject.patch fniessink, 2008-09-13 19:32
Messages
msg2939 Author: [hidden] (fniessink) Date: 2008-09-13 19:32
This patch makes if possible pass a subject to IssueClass.nosymessage(). This is handy if users want to create a custom subject in e.g. detectors/nosyreaction.py  instead of the subject that is generated by default.
msg5555 Author: [hidden] (rouilj) Date: 2016-04-30 03:51
Is there a case where the email subject should not
have the [issue3455] prefix?

I suggest that allowing the subject to be overridden is
useful, but I think the issue identifier should always be
prepended to the supplied or generates subject text.
msg5592 Author: [hidden] (rouilj) Date: 2016-06-11 04:47
Applied with a small change to the patch. Used subject=None rather than
subject="".

I decided against setting the [class#] prefix on the subject line. Added
to the docstring that the caller needs to add that if they want it.

Added a test case for the enhancement to tests/test_mailgw.py.

Once I finish running the test suite, I'll record checkin and close this.
msg5594 Author: [hidden] (rouilj) Date: 2016-06-11 22:08
committed at 786f0581bc90
History
Date User Action Args
2016-06-11 22:08:15rouiljsetmessages: + msg5594
2016-06-11 04:47:01rouiljsetstatus: open -> closed
type: rfe
resolution: fixed
messages: + msg5592
components: + Mail interface
2016-04-30 03:52:06rouiljsetassignee: rouilj
components: + Infrastructure, - None
2016-04-30 03:51:33rouiljsetmessages: + msg5555
2013-01-11 03:56:03rouiljsetnosy: + rouilj
2008-09-13 19:32:37fniessinkcreate