Roundup Tracker - Issues

Issue 2407750

classification
Add missing call to urllib.quote
Type: Severity: normal
Components: None Versions:
process
Status: closed fixed
:
: rouilj : cedric_krier, rouilj
Priority: normal : patch

Created on 2008-12-08 22:31 by cedric_krier, last changed 2016-05-09 00:13 by rouilj.

Files
File name Uploaded Description Edit Remove
roundup-quote.patch cedric_krier, 2008-12-08 23:24
Messages
msg2940 Author: [hidden] (cedric_krier) Date: 2008-12-08 22:31
Hi,

Here is a patch to add call to urllib.quote for args of indexargs_url
msg2941 Author: [hidden] (cedric_krier) Date: 2008-12-08 23:24
File Added: roundup-quote.patch
msg5550 Author: [hidden] (rouilj) Date: 2016-04-30 02:58
This looks like a valid patch.

the function being patch has a role of:

  Embed the current index args in a URL

and this looks like an obvious need to url quote the passed in value.
Unless somebody has an objection. I plan on applying this in a week
and making sure it doesn't break any tests before I check in.
msg5565 Author: [hidden] (rouilj) Date: 2016-05-09 00:13
Patch applied in commit: d7a4eeb7f843

No regressions in run_test.

Demo.py test seemed to work.

It would be nice to have an exact recipe for testing this patch but..
History
Date User Action Args
2016-05-09 00:13:02rouiljsetstatus: open -> closed
resolution: fixed
messages: + msg5565
2016-04-30 02:58:59rouiljsetassignee: rouilj
messages: + msg5550
nosy: + rouilj
2008-12-08 22:31:26cedric_kriercreate