Roundup Tracker - Issues

Issue 2550924

classification
devel tracker template missing some patch support
Type: Severity: normal
Components: Interface Versions: devel
process
Status: open
:
: : ezio.melotti, marthasimons, r.david.murray, rouilj
Priority: low :

Created on 2016-07-09 17:36 by rouilj, last changed 2019-05-16 23:55 by rouilj.

Messages
msg5792 Author: [hidden] (rouilj) Date: 2016-07-09 17:36
The devel tracker has support for displaying and tracking patches.
However a lot of it is commented out.

Needs somebody who knows how this should work to fix it.

Maybe some of the python.org folks know??
msg5808 Author: [hidden] (r.david.murray) Date: 2016-07-10 16:05
It looks like that template may indeed have been branched off our code
base at some point.  It isn't obvious to me what you mean by "a lot
of it is commented out", though.  What part of the code are you looking
at?  (I didn't spend a lot of time scanning it.)
msg5809 Author: [hidden] (rouilj) Date: 2016-07-10 17:01
In message <20160710160515.6997DB1415A@webabinitio.net>,
R David Murray writes:
>It looks like that template may indeed have been branched off our code
>base at some point.  It isn't obvious to me what you mean by "a lot
>of it is commented out", though.  What part of the code are you looking
>at?  (I didn't spend a lot of time scanning it.)

If you look at:

   share/roundup/templates/devel/html/bug.item.html

the patch code is all commented out:

<!--
<tr tal:condition="context/is_edit_ok">
 <th><tal:block i18n:translate="">Patch</tal:block>:</th>
 <td colspan="3">
...
 <th><tal:block i18n:translate="">Repo. Revision</tal:block>:</th>
 <td colspan=3><input type="edit" name="patches-1@revision" size="40"></td>
</tr>
-->

I am not sure if there are other similar templates.

Thanks for looking at this for me.
msg5820 Author: [hidden] (r.david.murray) Date: 2016-07-10 19:19
Hmm.  Looks like the template has different IssueClasses for different
things...we only have the one IssueClass, just like the classic template.
The fields in the bugs template sound kind of like our extra fields,
but the two templates are not similar enough to be informative.
Whatever origins of the code I don't think knowledge of the Python
tacker is going to help sorting out what this code is trying to do.
History
Date User Action Args
2019-05-16 23:55:24rouiljsetpriority: low
2019-05-12 20:46:41rouiljsetmessages: - msg6470
2019-05-02 11:25:39marthasimonssetnosy: + marthasimons
messages: + msg6470
2016-07-10 19:19:12r.david.murraysetmessages: + msg5820
2016-07-10 18:54:21rouiljsetstatus: new -> open
2016-07-10 17:01:27rouiljsetmessages: + msg5809
2016-07-10 16:05:18r.david.murraysetnosy: + r.david.murray
messages: + msg5808
2016-07-09 17:36:53rouiljcreate