Roundup Tracker - Issues

Issue 2550937

classification
Custom nosyreaction leads to crash (with fix)
Type: crash Severity: normal
Components: Infrastructure Versions: devel
process
Status: closed fixed
:
: rouilj : goobliata, rouilj
Priority: : patch

Created on 2017-04-01 20:45 by goobliata, last changed 2017-04-06 02:05 by rouilj.

Files
File name Uploaded Description Edit Remove
nosendto.diff goobliata, 2017-04-01 20:45 Fix
Messages
msg5950 Author: [hidden] (goobliata) Date: 2017-04-01 20:45
I attempted to make sure I receive email for all messages and ran into a
crash. In detectors/nosyreaction.py I added my email to the nosymessage
call. When nobody is subscribed to the issue (unassigned, nobody nosy)
roundup crashes when you do this. The fix is simple and a patch is attached.

The current code crashes because smtp_send is called with an empty list
(sendto) which throws an exception when smtplib.sendmail is called
eventually. The patch just prevents smtp_send from being called if
sendto is empty.
msg5954 Author: [hidden] (rouilj) Date: 2017-04-06 02:05
Hi Trent:

Thanks for the patch. I have applied it in change set 0121b2f1f041
to the core.

Closing.
History
Date User Action Args
2017-04-06 02:05:37rouiljsetstatus: new -> closed
assignee: rouilj
resolution: fixed
messages: + msg5954
nosy: + rouilj
2017-04-01 20:45:09goobliatacreate