Roundup Tracker - Issues

Message5686

Author jerrykan
Recipients jerrykan, rouilj
Date 2016-06-30.03:49:16
Message-id <d8251d03-bb19-de00-6cd4-4aefb5c0ac5d@jerrykan.com>
In-reply-to <1467238079.06.0.992581545299.issue2550910@psf.upfronthosting.co.za>
On 30/06/16 08:07, John Rouillard wrote:
> Sigh, John looks like your fix broke something else.
Argh. Serves me right for trying to push out some quick fixes. I've 
taken a bit of time to look at the problem properly and this time it was 
because I didn't look closely enough at the mark_class decorator when I 
copy and pasted it.

Details of the fix can be found in the commit message rev1c94afabb2cb

This time I promise everything should be in working order*

(* promise comes with no guarantee)

> Are you running a full test suite when trying to validate
> run_tests, or were you following my lead and only running the
> indexer stuff?

I run the full test suite using TravisCI before I push back my changes 
upstream, but that tests everything and doesn't skip anything, which is 
why I didn't pick up this problem. I also tested just test_indexer.py 
which didn't exhibit the problems we were hitting.

I've done a bit more manual testing of the tests this time, so hopefully 
it will all be good now.
History
Date User Action Args
2016-06-30 03:49:17jerrykansetrecipients: + jerrykan, rouilj
2016-06-30 03:49:17jerrykanlinkissue2550910 messages
2016-06-30 03:49:16jerrykancreate