Roundup Tracker - Issues

Issue 2550568

Title: Roundup nosy message bug
Type: behavior Severity: critical
Components: Mail interface Versions: devel
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: stefan Nosy List: ajaksu2, richard, stefan
Priority: immediate Keywords: patch

Created on 2009-07-15 18:36 by stefan, last changed 2009-07-20 06:25 by richard.

File name Uploaded Description Edit Remove
patch stefan, 2009-07-15 18:36 This patch is incomplete, please disregard.
patch stefan, 2009-07-15 18:37
msg3805 Author: [hidden] (stefan) Date: 2009-07-15 18:36
When sending a nosy message to more than one recipient, with an
attachment, the second and subsquent recipients did not recieve the
main body of the message.  Instead, they got the last attachment to
the message both as the main body and as an attachment.  And, not even
property encoded, resulting in garbage messages.

That's because Roundup 1.4.8 uses the "content" variable both to hold
the body of the message and the attachment.  Once its gone through the
loop over recipients, the original body has been overridden with the
last attachment.  Doh.

The attached patch fixes the issue as it avoids the variable clash by
renaming the first 'content' to 'body'.
msg3821 Author: [hidden] (richard) Date: 2009-07-20 06:25
Fixed (with changes to patch supplied) in r4329
Date User Action Args
2009-07-20 06:25:12richardsetstatus: new -> closed
resolution: fixed
messages: + msg3821
2009-07-15 18:37:50stefansetfiles: + patch
2009-07-15 18:36:15stefancreate