Issue 2550750
Created on 2012-03-18 21:30 by joseph_myers, last changed 2012-08-28 03:48 by jerrykan.
|
| File name |
Uploaded |
Description |
Edit |
Remove |
|
no-timeout-mail-patch
|
joseph_myers,
2012-03-18 21:30
|
patch to socket error handling |
|
|
|
| msg4518 |
Author: [hidden] (joseph_myers) |
Date: 2012-03-18 21:30 |
|
Roundup tries to detect certain network errors and not report them to
the tracker admin (roundup/cgi/client.py, IGNORE_NET_ERRORS). This does
not work reliably for timeouts, which produce the socket.timeout
exception rather than socket.error with ETIMEDOUT.
The attached patch deals with this by checking for socket.timeout before
socket.error.
|
| msg4519 |
Author: [hidden] (ber) |
Date: 2012-03-19 08:28 |
|
Joseph,
thanks for the report and the patch.
Next step would be to get another person to confirm both.
Do you know an easy way to reproduce the issue for testing?
Bernhard
|
| msg4520 |
Author: [hidden] (joseph_myers) |
Date: 2012-03-19 09:10 |
|
I don't have a way of reproducing timeouts on demand. I generally
observed the timeout exceptions being reported for large static images
served through Roundup (and empirically observed that the exception emails
did not appear for a month of having the patch installed, having been
quite frequent before then).
|
|
| Date |
User |
Action |
Args |
| 2012-08-28 03:48:08 | jerrykan | set | nosy:
+ jerrykan |
| 2012-03-19 09:10:28 | joseph_myers | set | messages:
+ msg4520 |
| 2012-03-19 08:28:54 | ber | set | priority: normal
nosy:
+ ber
messages:
+ msg4519
keywords:
+ patch |
| 2012-03-18 21:30:57 | joseph_myers | create | |
|