Roundup drops email signature from the message only when the signature
is between 2 and 10 lines:
http://roundup.hg.sourceforge.net/hgweb/roundup/roundup/file/default/roundup/mailgw.py#l1821
Longer signatures don't get dropped.
Is there a reason to keep the <= 10 part?

Originally reported at
http://psf.upfronthosting.co.za/roundup/meta/issue491

On Thu, Nov 08, 2012 at 05:41:19AM +0000, Ezio Melotti wrote:
> 
> Roundup drops email signature from the message only when the signature
> is between 2 and 10 lines:
> http://roundup.hg.sourceforge.net/hgweb/roundup/roundup/file/default/roundup/mailgw.py#l1821
> Longer signatures don't get dropped.
> Is there a reason to keep the <= 10 part?

I *think* the reason is that the email delimiter magic used
may be found (with low probability) in a message, so I guess
this limit is used to prevent whole message parts being dropped
accidentally.

Maybe make this another config-parameter for the email gateway?
Setting the default to 10 and take 0 for infinite?

So communities who still use the usenet maximum of 4 can lower
the limit :-)

Ralf

Ezio: Feel free to change the behaviour to what you think is good.

I can see the point that if there is a "-- " somewhere accidently
that roundup might throw away too much, but hey, I don't think that is a
big deal.

Should we make this a config.ini setting:

[mailgw]

# If leave_body_unchanged is set to no, roundup attempts
# to strip signatures. If the recognized signature is less than
# max_signature_length lines, it will be removed. Otherwise the
# signature will be kept.
max_signature_length = 10

Also should there be a minimum value like 3 or 4?

0 should be invalid (set leave_body_unchanged to yes or new
to disable)

-- rouilj

Nice to have addition, I personally don't remove signatures in my
trackers, though (also in the fear of losing something valuable because
people these days don't follow established signature conventions).