Roundup Tracker - Issues

Issue 2550908

classification
max_attachment_size in new config.ini is set ridiculously high on 64 bit python
Type: behavior Severity: normal
Components: Mail interface Versions: 1.5
process
Status: closed rejected
:
: rouilj : ThomasAH, rouilj, schlatterbeck
Priority: normal : Effort-Low

Created on 2016-05-29 22:29 by rouilj, last changed 2016-06-11 01:33 by rouilj.

Messages
msg5569 Author: [hidden] (rouilj) Date: 2016-05-29 22:29
The default value for max_attachment_size is set in
roundup/configuration.py. It is set to:


           (IntegerNumberOption, "max_attachment_size", sys.maxint,

sys.maxint is 2147483647 in 32 bit python ~ 2G. Large but not bad.
However on a 64 bit python we get: 9223372036854775807L

I suggest setting it to the 32 bit maxint (2^31 -1).
msg5570 Author: [hidden] (ThomasAH) Date: 2016-05-30 13:14
I assume the default value should mean "unlimited" anyway, so now it is
just more unlimited than with 32bit. 2GB is too high for most situations
anyway.

If there should be a default value that does not mean "unlimited", it
should match something that occurs in the wild, e.g. default limits of
postfix, gmail or whatever.
msg5571 Author: [hidden] (schlatterbeck) Date: 2016-05-31 11:27
On Sun, May 29, 2016 at 10:29:54PM +0000, John Rouillard wrote:
> 
> The default value for max_attachment_size is set in
> roundup/configuration.py. It is set to:
> 
> 
>            (IntegerNumberOption, "max_attachment_size", sys.maxint,
> 
> sys.maxint is 2147483647 in 32 bit python ~ 2G. Large but not bad.
> However on a 64 bit python we get: 9223372036854775807L
> 
> I suggest setting it to the 32 bit maxint (2^31 -1).

Maxint means "unlimited".
So the default is no limit on attachment size.
I wouldn't change this in the defaults.

Ralf
History
Date User Action Args
2016-06-11 01:33:37rouiljsetstatus: new -> closed
type: behavior
resolution: rejected
2016-05-31 11:27:55schlatterbecksetnosy: + schlatterbeck
messages: + msg5571
2016-05-30 13:14:29ThomasAHsetnosy: + ThomasAH
messages: + msg5570
2016-05-29 22:29:53rouiljcreate