Roundup Tracker - Issues

Issue 873534

classification
valid css for classic template
Type: Severity: normal
Components: User Interface Versions:
process
Status: closed fixed
:
: richard : ax-, richard
Priority: normal : patch

Created on 2004-01-09 04:56 by ax-, last changed 2004-01-21 01:29 by richard.

Files
File name Uploaded Description Edit Remove
style.patch ax-, 2004-01-09 04:56
classic_style.css.patch ax-, 2004-01-20 09:00
Messages
msg2677 Author: [hidden] (ax-) Date: 2004-01-09 04:56
the current templates/classic/html/style.css doesn't 
validate at http://jigsaw.w3.org/css-validator/. this is 
mostly due to missing length units on non-zero values 
(eg. padding: 1 0 0 1).

attached patch
* adds these missing length units (px)
* removes length units from zero values
* removes / merges redeclared selectors and elements 
with the the same declaration-blocks
* adds background-color: to selectors with color: ("good 
practice to avoid conflicts with user stylesheets")
* uses short rgb color notation (#444 instead of 
#444444) where applicable
* uses short values margins and paddings (margin: 0 
instead of margin: 0 0 0 0) where applicable

and makes the file validate. it applies with patch -p0 in 
templates/classic/html. a similar fix should be applied to 
the 'minimal' stylesheet.
msg2678 Author: [hidden] (richard) Date: 2004-01-19 22:56
Logged In: YES 
user_id=6405

Patch failed :( 
 
I've recently made some changes - would you mind 
re-generating the patch against the CVS HEAD? 
msg2679 Author: [hidden] (ax-) Date: 2004-01-20 09:00
Logged In: YES 
user_id=700629

updated patch attached
msg2680 Author: [hidden] (richard) Date: 2004-01-21 01:29
Logged In: YES 
user_id=6405

Applied, thanks. 
History
Date User Action Args
2004-01-09 04:56:49ax-create