Roundup Tracker - Issues

Message5564

Author techtonik
Recipients antmail, ber, rouilj, techtonik
Date 2016-05-07.07:11:55
Message-id <CAPkN8xL=Awg+rGR8hufYa61GDVAcuS+3o=obTH02uwoNVsu3wA@mail.gmail.com>
In-reply-to <1462230839.53.0.244911556619.issue2550890@psf.upfronthosting.co.za>
I am trying to take a look at this, but getting constantly
distracted. Jinja2 issue about adding {debug} builtin is
here:

https://github.com/pallets/jinja/issues/174#issue-10048682

The line in return statement should be """ """.format() string
for readability.

It would be nice to see test output and, ideally, test for it,
also submitted to upstream, so we won't have to maintain
this ourselves.

Protected _attributes are probably fine, __private could be
hidden.

additional_filters declaration should be placed on top
before it is used in the text.

And the distractions I am thinking of is to be able to run
Jinja2 test on https://sandstorm.io/ =)

On Tue, May 3, 2016 at 2:13 AM, John Rouillard
<issues@roundup-tracker.org> wrote:
>
> John Rouillard added the comment:
>
> Anatoly,
>
> Anthony requested that you look at this patch to see if it needs to
> be/should merged.
>
> Can you take a look and leave a note.
>
> Thanks
>
> -- rouilj
>
> ________________________________________________
> Roundup tracker <issues@roundup-tracker.org>
> <http://issues.roundup-tracker.org/issue2550890>
> ________________________________________________
History
Date User Action Args
2016-05-07 07:11:56techtoniksetrecipients: + techtonik, ber, rouilj, antmail
2016-05-07 07:11:56techtoniklinkissue2550890 messages
2016-05-07 07:11:55techtonikcreate