Message5687
On 28/06/16 22:08, John Rouillard wrote:
> Hmm, mysql IIRC tries to conenct to the db as part of have_backend()
> or some wrapper around have_backend() in the tests. If it can't
> connect it skips.
The bit of code you are interested in is at:
https://sourceforge.net/p/roundup/code/ci/1c94afabb2/tree/test/test_mysql.py#l47
which in addition to checking id the backend exists, attempts to check
if the database exists as well, using:
https://sourceforge.net/p/roundup/code/ci/1c94afabb2/tree/roundup/backends/back_mysql.py#l98
I am not entirely convinced that this extra checking is desirable. If
the database does not exist I would prefer that the tests fail loudly
rather than skip silently (and potentially go unnoticed).
So my opinion would be that the logic used to determine if the the mysql
tests are skipped should be the same as postgresql, not vice-versa.
Maybe this discussion should happen in another issue? or on the mailing
list so others can add their opinion? |
|
Date |
User |
Action |
Args |
2016-06-30 04:00:23 | jerrykan | set | recipients:
+ jerrykan, rouilj |
2016-06-30 04:00:23 | jerrykan | link | issue2550910 messages |
2016-06-30 04:00:23 | jerrykan | create | |
|