Roundup Tracker - Issues

Issue 1031271

classification
otk_value is too short
Type: Severity: normal
Components: Database Versions:
process
Status: closed fixed
:
: richard : chrisgltt, richard, tepperly
Priority: normal :

Created on 2004-09-20 15:19 by tepperly, last changed 2004-09-23 21:30 by richard.

Messages
msg1451 Author: [hidden] (tepperly) Date: 2004-09-20 15:19
 I just set up a new Roundup tracker, and I couldn't
register because the information in my registration was
longer than the 255 characters allocated for otk_value.
This causes a traceback when I try to confirm
registration. Here is the line from mysql with certain
characters changes to x.

mysql> select * from otks;

| A9KXXXXWOwcVhTEovJI5bEjIfeSJ6rFp | {'username':
'epperly', 'phone': 'xxx-xxx-xxxx',
'alternate_addresses':
'xxxxxxxx@llnl.gov\nxxxxxxxxxx@comcast.net',
'realname': 'Tom Epperly', 'address':
'xxxxxxxx@llnl.gov', 'organisation': 'CASC/LLNL',
'password': '{SHA}4249xxx64dd9ea5b65e1f750cabfc190 |
1.09545e+09 |

The closing single quote is missing, so the following
traceback occurs.

A problem occurred while running a Python script. Here
is the sequence of function calls leading up to the
error, with the most recent (innermost) call first. The
exception attributes are:
      __doc__ = 'Invalid syntax.'
      __getitem__ = <bound method
SyntaxError.__getitem__ of <exceptions.SyntaxError
instance>>
      __init__ = <bound method SyntaxError.__init__ of
<exceptions.SyntaxError instance>>
      __module__ = 'exceptions'
      __str__ = <bound method SyntaxError.__str__ of
<exceptions.SyntaxError instance>>
      args = ('EOL while scanning single-quoted
string', (None, 1, 255, "{'username': 'epperly',
'phone': 'xxx-xxx-xxxx',...password':
'{SHA}4249xxx64dd9ea5b65e1f750cabfc190"))
      filename = None
      lineno = 1
      msg = 'EOL while scanning single-quoted string'
      offset = 255
      print_file_and_line = None
      text = "{'username': 'epperly', 'phone':
'xxx-xxx-xxxx',...password':
'{SHA}4249xxx64dd9ea5b65e1f750cabfc190"

/usr/local/roundup-0.7.5/lib/python2.3/site-packages/roundup/backends/sessions_rdbms.py
in
getall(self=<roundup.backends.sessions_rdbms.OneTimeKeys
instance>, infoid='A9KXXXXWOwcVhTEovJI5bEjIfeSJ6rFp')
   48         if not res:
   49             raise KeyError, 'No such %s
"%s"'%(self.name, infoid)
   50         return eval(res[0])
      global eval = undefined, res = ("{'username':
'epperly', 'phone': 'xxx-xxx-xxxx',...password':
'{SHA}4249xxx64dd9ea5b65e1f750cabfc190",)
   51 
   52     def set(self, infoid, **newvalues):

/usr/local/roundup-0.7.5/lib/python2.3/site-packages/roundup/roundupdb.py
in confirm_registration(self=<myroundsql 0x40964b8c>,
otk='A9KXXXXWOwcVhTEovJI5bEjIfeSJ6rFp')
   61 
   62     def confirm_registration(self, otk):
   63         props = self.getOTKManager().getall(otk)
      props = undefined, self = <myroundsql
0x40964b8c>, global getOTKManager = undefined, global
getall = undefined, otk =
'A9KXXXXWOwcVhTEovJI5bEjIfeSJ6rFp'
   64         for propname, proptype in
self.user.getprops().items():
   65             value = props.get(propname, None)

/usr/local/roundup-0.7.5/lib/python2.3/site-packages/roundup/cgi/actions.py
in handle(self=<roundup.cgi.actions.ConfRegoAction
instance>)
  665         except (ValueError, KeyError), message:
  666            
self.client.error_message.append(str(message))
  667             return
  668 
  669         # log the new user in

/usr/local/roundup-0.7.5/lib/python2.3/site-packages/roundup/cgi/actions.py
in execute(self=<roundup.cgi.actions.ConfRegoAction
instance>)
   32         """Execute the action specified by this
object."""
   33         self.permission()
   34         return self.handle()
      self = <roundup.cgi.actions.ConfRegoAction
instance>, global handle = undefined
   35 
   36     name = ''

/usr/local/roundup-0.7.5/lib/python2.3/site-packages/roundup/cgi/client.py
in
handle_action(self=<_roundup_tracker_1.interfaces.Client
instance>)
  592 
  593         except ValueError, err:
  594             self.error_message.append(str(err))
      self = <_roundup_tracker_1.interfaces.Client
instance>, global error_message = undefined, global
append = undefined, global str = undefined, err = undefined
  595 
  596     def write(self, content):

/usr/local/roundup-0.7.5/lib/python2.3/site-packages/roundup/cgi/client.py
in
inner_main(self=<_roundup_tracker_1.interfaces.Client
instance>)
  251         except:
  252             # everything else
  253             self.write(cgitb.html())
      self = <_roundup_tracker_1.interfaces.Client
instance>, global write = undefined, global cgitb =
<module 'roundup.cgi.cgitb' from
'/usr/local/rou...b/python2.3/site-packages/roundup/cgi/cgitb.pyo'>,
html = undefined
  254 
  255     def clean_sessions(self):

 
msg1452 Author: [hidden] (tepperly) Date: 2004-09-20 15:28
Logged In: YES 
user_id=94539

For my online system, I tried doing
mysql> alter table otks modify otk_value text;
This allows otk_value to be up to 65535 characters long.
msg1453 Author: [hidden] (chrisgltt) Date: 2004-09-23 15:58
Logged In: YES 
user_id=1112215

I got the same problem as you, does anybody know how to 
solve it?
msg1454 Author: [hidden] (tepperly) Date: 2004-09-23 16:47
Logged In: YES 
user_id=94539

Another work around would be to use the shortest possible
registration. For example, leave out your alternative email
addresses, abbreviate your real name, etc. Once you've
created and authenticated your new account, you can change
your profile and add information.
msg1455 Author: [hidden] (chrisgltt) Date: 2004-09-23 17:12
Logged In: YES 
user_id=1112215

tepperly,
I wonder if there is any problem for changing the type of 
column otk_value since this table is used everywhere in 
roundup.

BTW, did you get the error page when you use the group on 
and sort on option on the priority field in search issue page?
Chris
msg1456 Author: [hidden] (richard) Date: 2004-09-23 21:30
Logged In: YES 
user_id=6405

Changing the column from VARCHAR(255) to TEXT is fine - 
that's what the next bugfix release will do. No other changes are 
required. 
msg1457 Author: [hidden] (tepperly) Date: 2004-09-23 22:09
Logged In: YES 
user_id=94539

I haven't had any problems with column type text.
History
Date User Action Args
2004-09-20 15:19:45tepperlycreate