Roundup Tracker - Issues

Issue 1101548

classification
indexargs_form doesn't allow suppression of search_text
Type: Severity: normal
Components: Web interface Versions:
process
Status: closed fixed
:
: richard : fresh, richard
Priority: normal :

Created on 2005-01-13 11:03 by fresh, last changed 2005-02-14 04:29 by richard.

Files
File name Uploaded Description Edit Remove
templating.py.patch fresh, 2005-01-18 11:29
Messages
msg1822 Author: [hidden] (fresh) Date: 2005-01-13 11:03
I want to build a search form as follows:

<form method="POST" tal:attributes="action
string:${request/base}issue">
   <p class="classblock"
      
tal:condition="python:request.user.hasPermission('View',
'issue')">
    <b>Search</b><br>
   <tal:block tal:replace="structure
python:request.indexargs_form()" />
   <input name="@search_text" size="10"
tal:attributes="value request/search_text">
   <input type="submit" value="Go">
   </p>
</form>

...but there's no way for me to tell indexargs_form to
stop generating @search_text.

As a result, if this form is displayed on the search
results page (I want it shown on every page ;-) You get
two @search_text fields which resutls in the following
error:

  File
"C:\PYTHON23\lib\site-packages\roundup\cgi\templating.py",
line 1879, in _post_init
    self.search_text = self.form[name].value
AttributeError: 'list' object has no attribute 'value'
msg1823 Author: [hidden] (fresh) Date: 2005-01-13 11:12
Logged In: YES 
user_id=24723

here's a micro-patch against templating.py.
If you tell me what branches to update and what change logs
I should update, I'm happy to check this into CSV.
msg1824 Author: [hidden] (richard) Date: 2005-01-13 22:55
Logged In: YES 
user_id=6405

You're using 0.7, so you'll be wanting it applied to the maint-0-7 
branch. Then it'll need to go onto maint-0-8 and HEAD. A note in 
the CHANGES.txt file is good - under the 0.7.12 section in all 
branches. 
 
If you attach the patch to this bug (don't forget the stupid "no, 
really" checkbox), I can look at applying it to all the branches. 
 
msg1825 Author: [hidden] (fresh) Date: 2005-01-18 11:29
Logged In: YES 
user_id=24723

Thanks, here's the patch.

PS: sf have a muppet issue tracker, when is roundup
switching to using roundup?!
msg1826 Author: [hidden] (richard) Date: 2005-02-14 04:29
Logged In: YES 
user_id=6405

applied, thanks. 
History
Date User Action Args
2005-01-13 11:03:01freshcreate