Roundup Tracker - Issues

Issue 1413501

classification
error in bounce error handling
Type: Severity: normal
Components: Mail interface Versions:
process
Status: closed fixed
:
: richard : a1s, richard
Priority: normal :

Created on 2006-01-24 07:52 by a1s, last changed 2006-08-11 01:40 by richard.

Messages
msg2111 Author: [hidden] (a1s) Date: 2006-01-24 07:52
Traceback (most recent call last):
  File "X:\roundup\roundup\scripts\roundup_mailgw.py",
line 195, in ?
    run()
  File "X:\roundup\roundup\scripts\roundup_mailgw.py",
line 191, in run
    sys.exit(main(sys.argv))
  File "X:\roundup\roundup\scripts\roundup_mailgw.py",
line 143, in main
    return handler.do_pipe()
  File "X:\roundup\roundup\mailgw.py", line 327, in do_pipe
    self.main(s)
  File "X:\roundup\roundup\mailgw.py", line 480, in main
    return self.handle_Message(Message(fp))
  File "X:\roundup\roundup\mailgw.py", line 545, in
handle_Message
    for address, (code, reason) in error.keys():
AttributeError: MessageSendError instance has no
attribute 'keys'
msg2112 Author: [hidden] (richard) Date: 2006-01-25 02:40
Logged In: YES 
user_id=6405

This is related to bug 1190906 whose code was *poorly* 
written by me (ie. the fix assumed a dict result whereas 
the mailer code stringifies it) 
 
A quick hack fix would be to look for "unknown user 
account" in the error string. 
 
I suspect a better fix would be to squash and ignore any 
smtplib.SMTPException raised during the bounce_message 
call in mailer. 
 
What do you think? 
 
msg2113 Author: [hidden] (a1s) Date: 2006-01-25 07:19
Logged In: YES 
user_id=8719

as far as i understand, this is mostly a spam case (user is
not authorized to mail the tracker and cannot be mailed
back). so yes, i think it is ok to log and ignore all smtp
errors here.
msg2114 Author: [hidden] (richard) Date: 2006-08-11 01:40
Logged In: YES 
user_id=6405

Going with the squash option, with a note in the code to 
maybe do something better in the future.
History
Date User Action Args
2006-01-24 07:52:30a1screate