Roundup Tracker - Issues

Issue 1435335

classification
roundup_server.py expects accept-language header.
Type: Severity: normal
Components: Web interface Versions:
process
Status: closed fixed
:
: richard : a1s, jalanb, richard, stefan
Priority: normal :

Created on 2006-02-20 17:21 by stefan, last changed 2006-04-04 13:43 by jalanb.

Messages
msg2170 Author: [hidden] (stefan) Date: 2006-02-20 17:21
roundup_server.py expects the accept-language header to
be set (roundup_server.py:262), no matter the actual
configuration. This leads to the following stack trace
for browsers that don't provide it:

Traceback (most recent call last):
  File
"/usr/local/roundup-1.1.0/lib/python2.4/site-packages/roundup/scripts/ro\
undup_server.py", line 106, in run_cgi
    self.inner_run_cgi()
  File
"/usr/local/roundup-1.1.0/lib/python2.4/site-packages/roundup/scripts/ro\
undup_server.py", line 262, in inner_run_cgi
    env['HTTP_ACCEPT_LANGUAGE'] =
self.headers['accept-language']
  File "/usr/lib/python2.4/rfc822.py", line 390, in
__getitem__
    return self.dict[name.lower()]
KeyError: 'accept-language'

msg2171 Author: [hidden] (a1s) Date: 2006-02-21 05:39
Logged In: YES 
user_id=8719

duplicate of 1429646
msg2172 Author: [hidden] (stefan) Date: 2006-02-21 12:33
Logged In: YES 
user_id=764

No, this is not the same issue as 1429646.
For one, the error is still present in version 1.1
(which contains the fix for 1429646).

The access to the 'accept-language' key in this case
doesn't happen in client.py, but in roundup_server.py
(see my original stack trace).

The fix may be similar, though.
msg2173 Author: [hidden] (a1s) Date: 2006-02-22 05:43
Logged In: YES 
user_id=8719

uh, yes.  sorry for missing that.  should be fixed now.
msg2174 Author: [hidden] (jalanb) Date: 2006-04-04 13:43
Logged In: YES 
user_id=208216

What is the fix for this ?

I have run into the same problem running roundup 1.0.

I have tried applying the change found in roundup 1.1.1,
namely change line 262 to: 

env['HTTP_ACCEPT_LANGUAGE'] =
self.headers.get('accept-language')

But, no joy:
Traceback (most recent call last):
  File
"/usr/lib/python2.4/site-packages/roundup/scripts/roundup_server.py",
line 106, in run_cgi
    self.inner_run_cgi()
  File
"/usr/lib/python2.4/site-packages/roundup/scripts/roundup_server.py",
line 262, in inner_run_cgi
    env['HTTP_ACCEPT_LANGUAGE'] =
self.headers.get('accept-language')
  File "/usr/lib/python2.4/rfc822.py", line 390, in __getitem__
    return self.dict[name.lower()]
KeyError: 'accept-language'

msg2175 Author: [hidden] (jalanb) Date: 2006-04-04 14:40
Logged In: YES 
user_id=208216

Oops, Apologies for the stupid mistake, I was wrong to
re-open this: using self.headers.get() *does* fix the error. 

I had forgotten to restart roundup-server, but traceback
showed my changed line so I kept thinking my change was
applied and not working.

History
Date User Action Args
2006-02-20 17:21:12stefancreate