Issue 1540890
Created on 2006-08-15 19:49 by tobias-herp, last changed 2006-10-03 23:19 by richard.
File name |
Uploaded |
Description |
Edit |
Remove |
style.css.patch
|
tobias-herp,
2006-08-15 19:49
|
highlight input:focus etc. |
|
|
msg2861 |
Author: [hidden] (tobias-herp) |
Date: 2006-08-15 19:49 |
|
The patch highlights the currently active input element
using CSS (:focus).
For input elements of type "submit" or "button" it
tries to suppress the background change, but AFAIK, and
at the time of this writing, only Opera (v9.01) does
this right; SeaMonkey 1.0.4 (Gecko/20060729) can by no
means be convinced to use the inherited background (it
/would/ use any other value, including transparent, but
this doesn't look right either). The usage of
<button...> tags would avoid this problem.
No browser known to me changes the background of <input
type=file...> tags. MSIE 6.0 does nothing at all.
However, for the users of Opera, any flavour of Mozilla
etc. (and likely) the feature /is/ useful, especially
when the focus has been set programmatically (e.g.
because of missing fields, like it is done by the
checkRequiredFields function of sf.net issue 1539081).
|
msg2862 |
Author: [hidden] (tobias-herp) |
Date: 2006-08-15 20:08 |
|
Logged In: YES
user_id=805804
Alternatively, it would be possible to change the input
background for input[type="text"] and input[type="password"]
only. In this case we should take care that every input
field gets its type attribute, since Opera wouldn't do the
:focus highlighting otherwise.
|
msg2863 |
Author: [hidden] (tobias-herp) |
Date: 2006-08-15 21:29 |
|
Logged In: YES
user_id=805804
Submitted a Mozilla bug report:
https://bugzilla.mozilla.org/show_bug.cgi?id=348776
|
msg2864 |
Author: [hidden] (tobias-herp) |
Date: 2006-09-18 03:13 |
|
Logged In: YES
user_id=805804
patched style.css checked in; for input tags, the background
change requires the type attribute to be set (text,
password, checkbox or radio).
The input methods set a type=text attribute when no type is
specified.
|
msg2865 |
Author: [hidden] (a1s) |
Date: 2006-09-18 08:52 |
|
Logged In: YES
user_id=8719
input field for file upload in the item template is not
highlighted with mozilla firefox 1.5.0.7.
|
msg2866 |
Author: [hidden] (tobias-herp) |
Date: 2006-09-20 07:00 |
|
Logged In: YES
user_id=805804
Yes, that's a problem; "file" type input fields can't be
addressed directly via CSS. The background might get
highlighted if the rule would address all input tags
(regardless of the type), but this would address buttons,
too; resetting this for button types leads to new problems.
|
msg2867 |
Author: [hidden] (tobias-herp) |
Date: 2006-09-20 19:05 |
|
Logged In: YES
user_id=805804
Yes, that's a problem; "file" type input fields can't be
addressed directly via CSS. The background might get
highlighted if the rule would address all input tags
(regardless of the type), but this would address buttons,
too; resetting this for button types leads to new problems.
|
msg2868 |
Author: [hidden] (a1s) |
Date: 2006-09-21 05:04 |
|
Logged In: YES
user_id=8719
it makes the interface inconsistent: similarily looking
fields behave differently. in my humble opinion, that
nullifies the positive effect of highlighting the focused
field and makes user interface worse than it was without
highlighting.
higlighting is good, but this emplementation just does not work.
|
msg2869 |
Author: [hidden] (richard) |
Date: 2006-10-03 23:19 |
|
Logged In: YES
user_id=6405
The lack of highlighting in the file input doesn't bother
me. I'm happy to leave the implementation as-is for now.
|
|
Date |
User |
Action |
Args |
2006-08-15 19:49:45 | tobias-herp | create | |
|