Roundup Tracker - Issues

Issue 1574467

classification
issue index in classic template handling of search_text
Type: Severity: normal
Components: None Versions:
process
Status: closed fixed
:
: : htrd, richard
Priority: normal : patch

Created on 2006-10-10 12:35 by htrd, last changed 2006-11-09 01:16 by richard.

Files
File name Uploaded Description Edit Remove
page.html.diff htrd, 2006-10-10 12:35
Messages
msg2873 Author: [hidden] (htrd) Date: 2006-10-10 12:35
indexargs_url produces a url using information from 
two sources; the parameters from the current request, 
and the parameters of that indexargs_url method. The 
call to indexargs_url for "Show Unassigned" and "Show 
All" fails to override any search_text. This leads to 
the following unexpected scenario:

a. Type some text in the top-right search box, and 
press the search button.
b. You see a subset of all issue; only those matching 
that search.
c. Click on "all issues".
d. You expect to see everything, but actually see the 
same subset from b.

The attached patch fixes this by explictly clearing 
search_text in those two calls to indexargs_url.

This patch also includes two less critical changes:

a. Include the requested search_text as the default 
value for the search input control. The current 
behaviour always leaves this control blank. This is 
handy as a reminder about what you searched for, and 
for refining searches.

b. I changed the 'Your Actions' link to use 
indexargs_url, for consistency.
msg2874 Author: [hidden] (richard) Date: 2006-11-09 01:16
Logged In: YES 
user_id=6405

Thanks!
History
Date User Action Args
2006-10-10 12:35:16htrdcreate