Roundup Tracker - Issues

Issue 1714899

classification
Feature Request: Optional Change Note
Type: rfe Severity: normal
Components: None Versions: 1.4
process
Status: fixed fixed
:
: rouilj : ajaksu2, chichi, rouilj
Priority: normal : patch

Created on 2007-05-08 12:07 by anonymous, last changed 2016-07-01 00:56 by rouilj.

Files
File name Uploaded Description Edit Remove
quiet_properties.diff ajaksu2, 2009-04-06 05:02 Add a .quiet attribute to roundupdb._Type and ignore properties if it's True
Messages
msg3479 Author: [hidden] (anonymous) Date: 2007-05-08 12:07
Sorry for using bug tracker for a feature request but wasn't sure where this belongs. We haven't figured out (there might be a way) how to disable change note about attribute changes from tracker emails. In external "client" interface we would not life those to be visible and in internal trackers they would be most convenient.

If there is no configurable way to decide if assignedto, status, priority etc. changes are appended to tracker emails, would it be possible to have a per instance confuration option for that.

Since we weren't smart enough to figure out how to override current behaviour from the per instance extensions/, we ended up doing like this:

19c19
< # $Id$
---
> # $Id: roundupdb.py,v 1.1 2006/07/17 12:05:51 root Exp $
322,323c322,323
<         if note:
<             m.append(note)
---
>         #if note:
>         #    m.append(note)

Huge thanks for considering this!
msg3658 Author: [hidden] (ajaksu2) Date: 2009-03-17 21:22
This patch addresses this RFE by adding a 'mute' parameter to
roundupdb.IssueClass.nosymessage that omits the change note.

It allows one to omit non-journaled *Link properties from an issue
change note by setting a 'quiet' parameter in nosymessage() that reaches
generate[Create|Change]Note().

It also addresses http://psf.upfronthosting.co.za/roundup/meta/issue249
and this RFE by allowing one to hide any non-*Link properties by setting
an attribute 'do_journal=False' on them. This affects both change notes
and history (in templating).

Example usage in schema.py:
nosy_count = Number()
nosy_count.do_journal = False
issue = IssueClass(db, "issue",
                   type=Link('issue_type'),
                   [...]
                   nosy_count=nosy_count)
msg3684 Author: [hidden] (ajaksu2) Date: 2009-04-06 05:02
Here's a cleaner version of the support for quiet properties (the
downstream issue).

Example usage in schema.py:
nosy_count = Number()
nosy_count.quiet = True
issue = IssueClass(db, "issue",
                   type=Link('issue_type'),
                   [...]
                   nosy_count=nosy_count)


If there is still interest in an option to mute/omit selected properties
when calling roundupdb.IssueClass.nosymessage, I can update that part too.
msg4096 Author: [hidden] (chichi) Date: 2010-07-16 08:37
Could you update an option to mute/omit selected properties
when calling roundupdb.IssueClass.nosymessage?

Thanks a ton!
msg5556 Author: [hidden] (rouilj) Date: 2016-04-30 04:15
This patch also looks useful even in its current state
where changes to a property will not be included in a
nosymessage by default if the quiet flag is set.

Daniel, did you ever generate a patch to suppress property
change reports for particular properties when calling
roundupdb.IssueClass.nosymessage?
msg5691 Author: [hidden] (rouilj) Date: 2016-07-01 00:56
Committed as: 8901cc4ef0e0

I updated the patch so that:

  prop=String(quiet=True)

works as well as:

  prop=String()
  prop.quiet=True

It also works when using the anydb backend.

Also the history) command in templating allows showall=True 
argument to ignore the quiet setting for properties.
History
Date User Action Args
2016-07-01 00:56:42rouiljsetstatus: open -> fixed
resolution: fixed
messages: + msg5691
2016-04-30 04:15:18rouiljsetassignee: rouilj
messages: + msg5556
nosy: + rouilj
2010-07-16 08:37:04chichisetnosy: + chichi
messages: + msg4096
2009-04-06 05:02:38ajaksu2setfiles: + quiet_properties.diff
messages: + msg3684
2009-04-06 04:56:09ajaksu2setfiles: - mute_omit_properties.diff
2009-03-17 21:22:58ajaksu2setfiles: + mute_omit_properties.diff
keywords: + patch
messages: + msg3658
versions: + 1.4
2009-03-17 15:02:13ajaksu2setnosy: + ajaksu2
2007-05-08 12:07:15anonymouscreate