Issue 1842687
Created on 2007-12-02 14:38 by oefe, last changed 2016-07-22 20:41 by rouilj.
msg2500 |
Author: [hidden] (oefe) |
Date: 2007-12-02 14:38 |
|
After adding a keyword through the web interface, the interface is in "edit existing" mode, with the newly added keyword in the edit box. It would be more convenient if it allowed adding further keywords.
Moreover, "Edit Existing" looks very similar to "Create New", so one could easily think that you still are in create mode, and enter new keywords. At least, that's what happened to me. I entered 3 keywords in a row without noticing that the second and third were just edits to the first entry...
|
msg2501 |
Author: [hidden] (tobias-herp) |
Date: 2008-02-17 12:59 |
|
I agree; this happened to me, too.
|
msg5863 |
Author: [hidden] (rouilj) |
Date: 2016-07-17 01:25 |
|
Editing a created keyword rather than creating a new one has also
happened to me.
The attached patch adds a checkbox to keyword.item.html
to set a __redirect_to argument to point to the current
url (create keyword page).
It also adds support for handling __redirect_to to NewItemAction::handle().
By default it always turns on the "Continue adding keywords."
checkbox. I don't know if this is the best option. Do we need:
a per user setting added to the user class/object
do we need a tracker config setting to determine the default state
or is setting it to on the most likely desired option (which I think it
true).
Also I plan on adding this to all "keyword" items in the default
trackers except maybe the jinja based one.
Quips, comments, evasions, questions or answers?
-- rouilj
|
msg5884 |
Author: [hidden] (rouilj) |
Date: 2016-07-22 20:41 |
|
I applied the patch to implement the __redirect_to form variable for the
new action. I don't have any automated tests for it.
My attempts to mock up the proper environment using
EditItemAction tests as an example didn't work after
a couple of hours.
The doc was more code than the patch, and hand testing the change did
work, so I felt ok adding the patch.
See changeset: 63294ed25e84
Closing.
|
|
Date |
User |
Action |
Args |
2016-07-22 20:41:57 | rouilj | set | status: open -> fixed resolution: fixed messages:
+ msg5884 |
2016-07-17 01:25:42 | rouilj | set | files:
+ continue_adding_keywords.diff versions:
+ devel nosy:
+ rouilj messages:
+ msg5863 assignee: richard -> rouilj keywords:
+ patch, Effort-Low, jinja2 type: rfe |
2007-12-02 14:38:30 | oefe | create | |
|