Roundup Tracker - Issues

Issue 1911449

classification
prevent broken pipe errors in csv export
Type: Severity: normal
Components: None Versions:
process
Status: closed accepted
:
: : loewis, richard
Priority: normal : patch

Created on 2008-03-10 21:21 by loewis, last changed 2008-08-07 06:32 by richard.

Files
File name Uploaded Description Edit Remove
socket_op.diff loewis, 2008-03-10 21:21
Messages
msg2920 Author: [hidden] (loewis) Date: 2008-03-10 21:21
We frequently get emails from roundup about broken pipes in the ExportCSVAction, such as

Traceback (most recent call last):

  File "/home/roundup/roundup-production//lib/python2.4/site-packages/roundup/cgi/client.py", line 265, in inner_main
    html = self.handle_action()

  File "/home/roundup/roundup-production//lib/python2.4/site-packages/roundup/cgi/client.py", line 841, in handle_action
    return action_klass(self).execute()

  File "/home/roundup/roundup-production//lib/python2.4/site-packages/roundup/cgi/actions.py", line 39, in execute
    return self.handle()

  File "/home/roundup/roundup-production//lib/python2.4/site-packages/roundup/cgi/actions.py", line 994, in handle
    writer.writerow([str(klass.get(itemid, col)) for col in columns])

  File "socket.py", line 248, in write
    self.flush()

  File "socket.py", line 235, in flush
    self._sock.sendall(buffer)

error: (32, 'Broken pipe')

The attached patch prevents these errors, ignoring them the same way other write failures to the socket get ignored.
msg2921 Author: [hidden] (richard) Date: 2008-08-07 06:32
Patch applied, finally, thanks.
History
Date User Action Args
2008-03-10 21:21:02loewiscreate