Roundup Tracker - Issues

Issue 2550510

classification
Fix blobfiles bug
Type: behavior Severity: urgent
Components: Database Versions: devel
process
Status: closed fixed
:
: stefan : richard, stefan
Priority: : patch

Created on 2009-02-19 19:35 by stefan, last changed 2009-02-27 20:19 by stefan.

Files
File name Uploaded Description Edit Remove
blobfiles.py.diff stefan, 2009-02-19 19:35
Messages
msg3559 Author: [hidden] (stefan) Date: 2009-02-19 19:35
Here is a case leading to wrong behavior :

1. Make an edit to the "content" property of a file via a script.

2. The script crashed.  Thus, the database is neither committed, nor
   rolled back.

3. Ran the script again, this time to completion, and with a
   database commit.

Yet, the contents of the file did not change. So, the state of the
database after a commit does not match the expected state!

The problem is that Roundup is trying to avoid recording a
transaction hook for the same file twice (which is good, of course),
but based that decision on whether the temporary file already existed
(which is bad, since it exists in the crash scenario above).

Fixed with the attached patch.
msg3609 Author: [hidden] (stefan) Date: 2009-02-27 20:19
Fixed with rev:4176.
History
Date User Action Args
2009-02-27 20:19:03stefansetstatus: new -> closed
resolution: fixed
messages: + msg3609
2009-02-19 19:35:07stefancreate