Roundup Tracker - Issues

Issue 2550519

classification
run_tests.py broken: cannot import name check_manifest
Type: crash Severity: major
Components: Infrastructure Versions: devel
process
Status: closed fixed
:
: stefan : richard, stefan, tobias-herp
Priority: : patch

Created on 2009-02-24 11:28 by tobias-herp, last changed 2009-02-27 16:12 by stefan.

Files
File name Uploaded Description Edit Remove
check_manifest-error.txt tobias-herp, 2009-02-24 11:28 complete output of failing run_tests.py
run_tests.py.patch tobias-herp, 2009-02-24 12:16
Messages
msg3587 Author: [hidden] (tobias-herp) Date: 2009-02-24 11:28
After updating Roundup, run_tests.py won't work anymore; see attached
patch.  Perhaps related to recent refactoring of setup.py?

This command (testing anypy, issue 2550503) worked before; running the
specific test directly still works.

Python 2.6.1, Windows XP; same problem for Python 2.3, 2.4, 2.5
(sys.path varying); for Python 2.4, it has worked for me before (with
2.3, run_tests.py won't work for me because I don't have a win32con for it)
msg3588 Author: [hidden] (stefan) Date: 2009-02-24 11:57
Yes, I have noticed that dependency, too. However, I'm not sure what the
right thing to do is, as I'm unconvinced that running this
'check_manifest()' function as a test is such a good idea.
First, it requires Roundup to be built (and thus should be disabled when
run in the source tree), and second, the same function is run during the
build procedure itself, too.

In fact, I'm not sure I see the need for this function at all. As it
compares existing files with the files from MANIFEST (a file that itself
has been built by listing existing files matching some glob pattern), it
seems a bit redundant.
Richard, do you have an opinion on this ? Can thie check_manifest()
function go ?
msg3589 Author: [hidden] (tobias-herp) Date: 2009-02-24 12:16
Patch, reflecting refactored directory structure
msg3607 Author: [hidden] (stefan) Date: 2009-02-27 16:12
After being told that several '*.~' files are 'missing', I decided
check_manifest() is just the wrong function to call from within
run_tests.py, and so I removed it with rev:4173. 
(It may make sense as part of the build, but even there I'm not fully
convinced. But this is for another issue, another day...)
History
Date User Action Args
2009-02-27 16:12:40stefansetstatus: open -> closed
resolution: fixed
messages: + msg3607
2009-02-24 12:16:31tobias-herpsetfiles: + run_tests.py.patch
keywords: + patch
messages: + msg3589
2009-02-24 11:57:56stefansetstatus: new -> open
assignee: stefan
messages: + msg3588
nosy: + richard
2009-02-24 11:28:58tobias-herpcreate