Roundup Tracker - Issues

Issue 2550687

classification
Xapian API usage improvements
Type: Severity: minor
Components: Database Versions: 1.4
process
Status: closed fixed
:
: ber : ber, olly, tonimueller
Priority: normal : patch

Created on 2011-01-31 06:49 by olly, last changed 2011-07-01 13:24 by ber.

Files
File name Uploaded Description Edit Remove
roundup-xapian-improve-api-usage.patch olly, 2011-01-31 06:49 Patch
Messages
msg4232 Author: [hidden] (olly) Date: 2011-01-31 06:49
While looking into 2550676 I noticed some of the Xapian API usage in
roundup could be improved.  Being able to pass a term to
"replace_document" is an old feature (added in Xapian 0.8.2, roundup
requires Xapian > 1.0).  This change should speed up indexing a little.

Also, add_term() is better than add_posting() since it is pointless to
be storing positional information for these terms.  This change will
reduce database size a little.

The patch is untested I'm afraid - I will try to find time to test it,
but thought it worth filing this so the patch doesn't get lost, and so
anyone enthusiastic can look at it if they want.
msg4234 Author: [hidden] (ber) Date: 2011-01-31 17:44
Olly, also thanks for this patch. Let me know if you could test it.
msg4316 Author: [hidden] (ber) Date: 2011-07-01 13:24
Tested with Debian GNU/Linux Lenny and 
Package: libxapian15 Version: 1.0.7-4
Revision: 4622 + Patch.

used an old demo instance with the new code, could search.
Added issues, could search for the new keywords.
Did an roundup-admin reindex, and searched again.

Committed with Rev4623.
History
Date User Action Args
2011-07-01 13:24:04bersetstatus: open -> closed
nosy: + tonimueller
resolution: fixed
messages: + msg4316
2011-07-01 11:16:29bersetstatus: new -> open
assignee: ber
priority: normal
2011-01-31 17:44:08bersetnosy: + ber
messages: + msg4234
2011-01-31 06:49:20ollycreate