Roundup Tracker - Issues

Issue 2550728

classification
remove buggy parentheses in TAL/DummyEngine.py
Type: compile error Severity: minor
Components: Versions: 1.4
process
Status: closed fixed
:
: : ber, hemmecke, jerrykan
Priority: : patch

Created on 2011-09-23 20:37 by hemmecke, last changed 2011-09-26 07:53 by ber.

Files
File name Uploaded Description Edit Remove
0001-remove-buggy-parentheses.patch hemmecke, 2011-09-23 20:37 Bugfix
Messages
msg4433 Author: [hidden] (hemmecke) Date: 2011-09-23 20:37
Originally posted in PS of
http://sourceforge.net/mailarchive/message.php?msg_id=28130734

Copied here to be self-contained. Fix is attached.
=============================================================
PS: Another thing that I've stumpled upon... I've found that in the log 
of the last command from above.
http://docs.python.org/reference/simple_stmts.html#grammar-token-assert_stmt
Should I put this into the bug tracker?

/home/hemmecke/scratch/roundup-git/local/lib/python2.7/site-packages/roundup/cgi/TAL/DummyEngine.py:82:

SyntaxWarning: assertion is always true, perhaps remove parentheses?
   assert (expression.startswith("$") and expression.endswith("$"),
/home/hemmecke/scratch/roundup-git/local/lib/python2.7/site-packages/roundup/cgi/TAL/DummyEngine.py:103:

SyntaxWarning: assertion is always true, perhaps remove parentheses?
   assert (expression.startswith("$") and expression.endswith("$"),
/home/hemmecke/scratch/roundup-git/local/lib/python2.7/site-packages/roundup/cgi/TAL/DummyEngine.py:165:

SyntaxWarning: assertion is always true, perhaps remove parentheses?
   assert (macroName.startswith("$") and macroName.endswith("$"),


(This is part of "git blame roundup/cgi/TAL/DummyEngine.py")
^43d208f (stefan 2009-02-09 17:47:12 +0000 102)     def evaluate(self, 
expression):
^43d208f (stefan 2009-02-09 17:47:12 +0000 103)         assert 
(expression.startswith("$") and expression.endswith("$"),
^43d208f (stefan 2009-02-09 17:47:12 +0000 104)             expression)
msg4434 Author: [hidden] (jerrykan) Date: 2011-09-26 00:35
related to issue2550714 ?
msg4435 Author: [hidden] (ber) Date: 2011-09-26 07:53
Patch committed with rev4646.
The included TAL might be old, but there is no reason to not fix 
a simple issue as long as this is inside of roundup I guess.

Thanks Ralf!

@John: You are right that this issues fixes a part of
   Issue2550714
History
Date User Action Args
2011-09-26 07:53:04bersetstatus: new -> closed
nosy: + ber
resolution: fixed
messages: + msg4435
title: remove buggy parentheses -> remove buggy parentheses in TAL/DummyEngine.py
2011-09-26 00:35:19jerrykansetnosy: + jerrykan
messages: + msg4434
2011-09-23 20:37:37hemmeckecreate