Roundup Tracker - Issues

Issue 2550783

classification
Typo in devel template
Type: behavior Severity: normal
Components: Install Problem (example) Versions: 1.4
process
Status: closed fixed
:
: rouilj : ber, pcaulagi, rouilj
Priority: normal : Effort-Low, patch

Created on 2012-11-24 14:37 by pcaulagi, last changed 2012-11-26 13:15 by ber.

Messages
msg4681 Author: [hidden] (pcaulagi) Date: 2012-11-24 14:37
There is a typo in the devel templates -
share/roundup/templates/devel/schema.py

Organisation is spelt once with a 'z' and once with a 's'.  So the user
will not be able to edit the organisation at all -

user = Class(db, "user",
             username=String(),
             password=Password(),
             address=String(),
             realname=String(),
             phone=String(),
             organisation=String(),
             alternate_addresses=String(),
             queries=Multilink('query'),
             roles=String(),     # comma-separated string of Role names
             timezone=String(),
             vcs_name=String())

p = db.security.addPermission(name='Edit', klass='user', check=own_record,
    description="User is allowed to edit their own user details",
    properties=('username', 'password',
                'address', 'realname',
                'phone', 'organization',
                'alternate_addresses',
                'queries',
                'timezone')) # Note: 'roles' excluded - users should not
be able to edit their own
msg4682 Author: [hidden] (rouilj) Date: 2012-11-25 22:58
I am changing organization to organisation since that is
how the field is identified in the database. I will assume the
original author was British 8-).
msg4683 Author: [hidden] (rouilj) Date: 2012-11-25 23:11
I have committed the change and a changelog entry. The resolution is
changed to fixed, but should the status be changed to open?

Is there a status for fixed in SVN but awaiting release?
msg4686 Author: [hidden] (ber) Date: 2012-11-26 13:15
Hi John,
thanks for commiting the fix!
(No there is no extra status for pending release. You could bring it up
on the devel list, if you want. Personally I think it may be a bit
too fine grained.)

Pradip, thanks for spotting the issue and the fix!

Bernhard
History
Date User Action Args
2012-11-26 13:15:02bersetstatus: open -> closed
nosy: + ber
messages: + msg4686
2012-11-25 23:11:43rouiljsetresolution: accepted -> fixed
messages: + msg4683
2012-11-25 22:58:01rouiljsetstatus: new -> open
nosy: + rouilj
messages: + msg4682
priority: normal
assignee: rouilj
keywords: + patch, Effort-Low
resolution: accepted
2012-11-24 14:37:56pcaulagicreate