Roundup Tracker - Issues

Issue 2550845

classification
Configure database backend in 'config.ini' instead of 'db/backend_name'
Type: Severity: normal
Components: Installation, Database Versions: devel
process
Status: closed accepted
:
: jerrykan : ThomasAH, ber, jerrykan
Priority: normal : patch

Created on 2014-06-18 04:50 by jerrykan, last changed 2016-01-15 03:56 by jerrykan.

Files
File name Uploaded Description Edit Remove
backend_name.patch jerrykan, 2014-06-18 04:50
backend_name_v2.patch jerrykan, 2014-12-22 03:18
Messages
msg5107 Author: [hidden] (jerrykan) Date: 2014-06-18 04:50
I'm not sure of the historical reasons why the database backend is
configure in the 'db/backend_name' file but (to me) it doesn't seem like
the most logical place for it to be configured, and can often (for me at
least) be another thing that I forget to configure when setting up or
migrating a tracker instance.

I have attached at patch that moves the configuration of the database
backend from the 'db/backend_name' file to the 'config.ini' file.

This will break backwards compatibility, so I would suggest waiting
until the 1.6 "branch" before committing it.

In the mean time I welcome comments or discussion about the merits (or
not) of keeping the 'db/backend_name' file around.
msg5108 Author: [hidden] (ThomasAH) Date: 2014-06-18 08:19
The reason probably is that the file is written by roundup-admin install
(since 2001) and writing config.ini is "new" (2004).

+1 for combining this in 1.6
msg5178 Author: [hidden] (jerrykan) Date: 2014-12-22 03:18
New version of the patch re-based on the current trunk, and adds a fix
to automatically create the 'db' directory for anydbm databases.
msg5182 Author: [hidden] (ber) Date: 2015-01-05 15:59
I think waiting for a 1.6 release maybe quite late to get this integrated.
This change would only affect anydbm users right? 
We could get migration information in the docs.
msg5183 Author: [hidden] (jerrykan) Date: 2015-01-06 00:26
On 06/01/15 02:59, Bernhard Reiter wrote:
> 
> Bernhard Reiter added the comment:
> 
> I think waiting for a 1.6 release maybe quite late to get this integrated.
> This change would only affect anydbm users right? 
> We could get migration information in the docs.
> 

The change is not backwards compatible and would impact all users
upgrading (ie. it would required all people upgrading to manually
editing their config.ini file). So with this in mind I don't think it is
a good candidate for a point release (eg. 1.5 -> 1.5.1).
msg5461 Author: [hidden] (jerrykan) Date: 2016-01-15 03:56
After fixing another bug, adding a deprecation warning and a little bit
of cleanup this has now been pushed:

  rev5251e97b1d
History
Date User Action Args
2016-01-15 03:56:39jerrykansetstatus: new -> closed
resolution: accepted
2016-01-15 03:56:17jerrykansetmessages: + msg5461
2015-01-06 00:26:20jerrykansetmessages: + msg5183
2015-01-05 15:59:52bersetnosy: + ber
messages: + msg5182
2014-12-22 03:18:43jerrykansetfiles: + backend_name_v2.patch
messages: + msg5178
2014-06-18 08:19:58ThomasAHsetnosy: + ThomasAH
messages: + msg5108
2014-06-18 04:50:34jerrykancreate