Roundup Tracker - Issues

Issue 2550917

classification
Add a: "Welcome user, you have logged in" ok_message on login.
Type: rfe Severity: normal
Components: Web interface Versions:
process
Status: fixed fixed
:
: : aburke, pefu, rouilj
Priority: normal : StarterTicket, patch

Created on 2016-07-05 02:55 by rouilj, last changed 2021-08-21 04:45 by rouilj.

Files
File name Uploaded Description Edit Remove
welcome.patch aburke, 2021-08-19 15:16 patched implement welcome banner
Messages
msg5754 Author: [hidden] (rouilj) Date: 2016-07-05 02:55
When a user logs out, they get a nice green banner saying

"You are logged out"

Why isn't there a "Welcome $user, you have logged in"

http://psf.upfronthosting.co.za/roundup/meta/file113/login_msg.diff

part of

http://psf.upfronthosting.co.za/roundup/meta/issue230

implements this (with different wording). I suggest we add somthing
similar to cgi/actions.py.

Thoughts?
msg5757 Author: [hidden] (pefu) Date: 2016-07-05 08:31
John Rouillard wrote:
> Why isn't there a "Welcome $user, you have logged in"
...
> Thoughts?

I'm +1 with this idea.  A patch however should take care of 
i18n of this welcome message text.

Regards, Peter.
msg5877 Author: [hidden] (rouilj) Date: 2016-07-20 01:07
Note that the user name can be: <b>demo</b>

this may cause an issue if it's used in certain contexts.

issue 2550921 updated to properly sanitize the login name.
msg7276 Author: [hidden] (rouilj) Date: 2021-06-10 01:53
Removing patch keyword as psf tracker is history and patch seems to be 
history. Adding StarterTicket for people looking for a 1-8 hour
task to learn.
msg7324 Author: [hidden] (aburke) Date: 2021-08-19 15:16
Here is an implementation and the patch is attached. There is also an 
email version that does not look like it came through, so it may be 
duplicated.
msg7326 Author: [hidden] (rouilj) Date: 2021-08-21 04:45
Committed on changeset:   6468:37b57da3374f

(https://sourceforge.net/p/roundup/code/ci/37b57da3374f209c4a8207272fbd08cf895fd0a6/)

CI/CD url: https://app.travis-ci.com/github/roundup-tracker/roundup/builds/235903843

codecov url: https://codecov.io/gh/roundup-tracker/roundup/commit/cd9e3812c95b2de36867a0aeead03a955d892b43/

Thanks aburke.

closing.
History
Date User Action Args
2021-08-21 04:45:51rouiljsetpriority: normal
status: new -> fixed
resolution: fixed
messages: + msg7326
2021-08-19 15:16:07aburkesetfiles: + welcome.patch
keywords: + patch
messages: + msg7324
nosy: + aburke
2021-06-10 01:53:35rouiljsetkeywords: + StarterTicket, - patch, Effort-Low
messages: + msg7276
2016-07-20 01:07:01rouiljsetmessages: + msg5877
2016-07-05 08:31:13pefusetnosy: + pefu
messages: + msg5757
2016-07-05 02:55:13rouiljcreate