Roundup Tracker - Issues

Issue 2551202

classification
mysqlRestTest.testRestRateLimit fails on slow machine
Type: Severity: normal
Components: Versions:
process
Status: fixed fixed
:
: : rouilj, schlatterbeck
Priority: :

Created on 2022-05-03 11:39 by schlatterbeck, last changed 2022-05-03 14:22 by schlatterbeck.

Messages
msg7489 Author: [hidden] (schlatterbeck) Date: 2022-05-03 11:39
On a slow machine I'm getting the following failed error for mysql:

        # value will be almost 60. Allow 1-2 seconds for all 20 rounds.
        self.assertAlmostEqual(
            float(self.server.client.additional_headers["X-RateLimit-Reset"]),
>           59, delta=1)
E       AssertionError: 57.706104 != 59 within 1 delta (1.2938959999999966 difference)

test/rest_common.py:1121: AssertionError

Should we live with this failing occasionally or make the error margin a little higher (I'd suggest 5 which should never fail and is about 10%)?
msg7491 Author: [hidden] (rouilj) Date: 2022-05-03 14:04
In message <1651577986.08.0.496676273549.issue2551202@roundup.psfhosted.org>,
Ralf Schlatterbeck writes:
>On a slow machine I'm getting the following failed error for mysql:
>
>        # value will be almost 60. Allow 1-2 seconds for all 20 rounds.
>        self.assertAlmostEqual(
>            float(self.server.client.additional_headers["X-RateLimit-Reset"]),
>>           59, delta=1)
>E       AssertionError: 57.706104 != 59 within 1 delta (1.2938959999999966 difference)
>
>Should we live with this failing occasionally or make the error margin
>a little higher (I'd suggest 5 which should never fail and is about 10%)?

I'm ok with 5.
msg7492 Author: [hidden] (schlatterbeck) Date: 2022-05-03 14:22
Ok, see commit 32c6e98e5a21, closing.
History
Date User Action Args
2022-05-03 14:22:34schlatterbecksetstatus: new -> fixed
resolution: fixed
messages: + msg7492
2022-05-03 14:04:26rouiljsetmessages: + msg7491
2022-05-03 11:39:46schlatterbeckcreate