Roundup Tracker - Issues

Issue 2551272

classification
test/test_templating.py::Markdown2TestCase::test_string_markdown_code_block_attribute fails
Type: compile error Severity: normal
Components: Test Versions: 2.2.0, 2.1.0
process
Status: fixed fixed
:
: rouilj : ceamac, rouilj
Priority: high :

Created on 2023-04-02 10:54 by ceamac, last changed 2023-04-02 18:19 by rouilj.

Files
File name Uploaded Description Edit Remove
roundup-test-failure.txt ceamac, 2023-04-02 10:54 the output with the failed assertion
Messages
msg7749 Author: [hidden] (ceamac) Date: 2023-04-02 10:54
Markdown2TestCase::test_string_markdown_code_block_attribute fails tests in 2.1.0 and 2.2.0 using python 3.10 or python 3.11.

I will attach the output.

Thank you!
msg7750 Author: [hidden] (rouilj) Date: 2023-04-02 18:19
Hello Viorel:

Thank you for the report and for using Roundup.

The test failure is a false positive. The code will work correctly in production.

This was addressed last October in development. The commit was:

====
changeset:   6995:dc83ebff4c90
user:        John Rouillard <rouilj@...>
date:        Sun Oct 02 23:18:43 2022 -0400
files:       test/html_norm.py test/test_templating.py
description:
change test to use html normalizer when comparing html output.

Update to Markdown2 parser changed text output keeping same html
semantics. Broke test_string_markdown_code_block_attribute test.  I
hand patched it to get tests working but it needed a better solution.

Write a simple html normalizer using HTMLParser so I don't need third
party (lxml, beautifulsoup) library to clean up the test.

Use the normalizer to parser the expected result and the result
returned by the various markdown libraries. Hopefully this will make
the test less fragile.

This can have multiple uses in template testing where html is
compared. I expect to have to change html_norm.py to make test
writing easier in the future.
=====

Have a great day and I hope you enjoy using Roundup.
History
Date User Action Args
2023-04-02 18:19:14rouiljsetstatus: new -> fixed
nosy: + rouilj
messages: + msg7750
priority: high
assignee: rouilj
resolution: fixed
2023-04-02 10:54:07ceamaccreate