Issue 2551275
Created on 2023-04-17 12:04 by joseph_myers, last changed 2023-05-24 03:37 by rouilj.
msg7759 |
Author: [hidden] (joseph_myers) |
Date: 2023-04-17 12:04 |
|
Python's ForkingMixIn has a max_children setting, default 40. This can be too small for busy Roundup installations; roundup-server should have a configuration option to change this value, to avoid needing to patch the code along the lines of
--- roundup_server.py.ORIG 2022-10-02 14:38:23.607161827 +0100
+++ roundup_server.py 2023-04-17 10:29:40.848711578 +0100
@@ -770,6 +770,7 @@
elif self["MULTIPROCESS"] == "fork":
class ForkingServer(socketserver.ForkingMixIn,
base_server):
+ max_children = 100
pass
server_class = ForkingServer
elif self["MULTIPROCESS"] == "thread":
to use a larger value.
|
msg7760 |
Author: [hidden] (schlatterbeck) |
Date: 2023-04-17 13:07 |
|
Wouldn't anyone using roundup in a large production setting use something like WSGI for that purpose? At least I do in trackers that have lots of clients.
It still is a good idea to make this configurable.
|
msg7762 |
Author: [hidden] (rouilj) |
Date: 2023-04-17 23:01 |
|
Agreed, it should be configurable. PTC.
|
msg7769 |
Author: [hidden] (rouilj) |
Date: 2023-05-24 03:37 |
|
Completed in:
changeset: 7387:46f92ac4e170
new -m and --max_children command line arguments and max_children config file setting for
roundup-server[.py].
CHANGES.txt, admin_guide.txt, roundup-server.1 updated.
Joseph I tested this manually and it seems to work. Can you please test this either from
the repo, or when I release the 2.3.0 beta in a week or so.
Thanks.
|
|
Date |
User |
Action |
Args |
2023-05-24 03:37:20 | rouilj | set | status: new -> fixed assignee: rouilj resolution: fixed messages:
+ msg7769 versions:
+ 2.3.0, - devel |
2023-04-17 23:01:49 | rouilj | set | nosy:
+ rouilj messages:
+ msg7762 |
2023-04-17 13:07:26 | schlatterbeck | set | nosy:
+ schlatterbeck messages:
+ msg7760 |
2023-04-17 12:04:12 | joseph_myers | create | |
|