Roundup Tracker - Issues

Issue 2551356

Add etag header when If-Modified-Since GET request returns not-modified (304)
Type: behavior Severity: normal
Components: Web interface Versions:
Status: new
: : rouilj
Priority: :

Created on 2024-06-03 02:10 by rouilj, last changed 2024-06-03 02:10 by rouilj.

msg8087 Author: [hidden] (rouilj) Date: 2024-06-03 02:10
You can do conditional requests in HTTP using an ETag with the If-None-Match header or a date 
with the If-Modified-Since header. This is supported for static files (/@@file/).

if-modified-since (ims) has been supported for a while, but reports that it
is not supplying the ETag header when returning a 304 not modified response.
I tried to fix this, but it's turning into a hairball so I am deferring the
fix/reorg until after 2.4.0 is released.

One issue I have is that the etag is different for different Content-Encodings. In
the REST flow, I just append the content-encoding (gzip, zstd, br) to the base etag

When I implemented support for If-None-Match, I was able to return the right
encoding sensitive etag because the encoding sensitive etag is sent by the browser.

With IMS, I don't have any hint about the encoding originally used to deliver the file.
I might have to make a best guess by treating it as a non-conditional get. Doing all
the work to figure out what headers and encoding I would send.
Date User Action Args
2024-06-03 02:10:43rouiljcreate