Roundup Tracker - Issues

Issue 2551358

classification
Remove html comments inside of script tags.
Type: behavior Severity: minor
Components: Web interface Versions:
process
Status: new
:
: : rouilj
Priority: : Effort-Low, StarterTicket

Created on 2024-06-19 01:54 by rouilj, last changed 2024-06-19 04:36 by rouilj.

Messages
msg8093 Author: [hidden] (rouilj) Date: 2024-06-19 01:54
A lot of the javascript in Roundup looks like:

  <script>
     <!--
    var text_field = document.frm_help.text_preview;
    original_field=form[field].value;
    text_field.value=original_field;
    //-->
  </script>

The html comment marker and (js) commented out end html comment marker
was a trick for netscape 1.0 to not show script code (since it didn't know to
hide stuff inside a script tag). It should be removed everywhere it occurs.

Since we don't have a javascript testing frame work in place, testing the
javascript will have to be manual.

This is a simple set of edits good for a first timer.

ref: https://stackoverflow.com/questions/808816/are-html-comments-inside-script-tags-a-best-
practice
History
Date User Action Args
2024-06-19 04:36:17rouiljsettitle: Remove htmll comments inside of script tags. -> Remove html comments inside of script tags.
2024-06-19 01:54:44rouiljcreate