Issue 479508
Created on 2001-11-08 10:08 by grubert, last changed 2001-11-09 06:54 by grubert.
msg64 |
Author: [hidden] (grubert) |
Date: 2001-11-08 10:08 |
|
if list issues is typed the program crashes.
i am unsure about the nesting of the tries.
|
msg65 |
Author: [hidden] (grubert) |
Date: 2001-11-08 10:12 |
|
Logged In: YES
user_id=147070
upload didnot work: the unidiff
--
Index: roundup-admin
===================================================================
RCS file: /cvsroot/roundup/roundup/roundup-admin,v
retrieving revision 1.40
diff -u -r1.40 roundup-admin
--- roundup-admin 2001/11/08 04:42:00 1.40
+++ roundup-admin 2001/11/08 10:04:37
@@ -664,7 +664,10 @@
# do the command
try:
- return function(args[1:])
+ try:
+ return function(args[1:])
+ except KeyError:
+ print 'Class not found: ',args[1:]
finally:
self.db.close()
|
msg66 |
Author: [hidden] (richard) |
Date: 2001-11-08 20:05 |
|
Logged In: YES
user_id=6405
I saw that additional try/except in the patch you mailed
me - but I'm unsure exactly what it's catching. You have
it reporting "Class not found". I presume that means you
tried a "list some_unknown_class" or something. In that
case, I think the do_list method should handle the
exception, not the function invoker - since there's so
many other ways different functions can raise a KeyError.
|
msg67 |
Author: [hidden] (grubert) |
Date: 2001-11-09 06:54 |
|
Logged In: YES
user_id=147070
the try catches a KeyError if an unknown_class is specified. at first i wanted to catch it inside the do_list, but then it would have to done in the other
do_ to (i am a programmer adhering to larry wall: being lazy).
if you insist i will put hte trys inside.
BUT maybe one should put it outside also, because i hate this break stuff, on the screen.
|
msg68 |
Author: [hidden] (richard) |
Date: 2001-11-09 10:11 |
|
Logged In: YES
user_id=6405
roundup-admin in CVS should now handle all exceptions from
the hyperdb properly.
|
|
Date |
User |
Action |
Args |
2001-11-08 10:08:54 | grubert | create | |
|