Roundup Tracker - Issues

Issue 618614

classification
db.user.filter() chokes on empty lists
Type: Severity: normal
Components: Mail interface Versions:
process
Status: closed fixed
:
: richard : lannert, richard
Priority: normal :

Created on 2002-10-04 15:49 by lannert, last changed 2002-10-07 00:50 by richard.

Messages
msg399 Author: [hidden] (lannert) Date: 2002-10-04 15:49
[This refers to roundup 0.5.0; sorry, I cannot specify
this in the sf
bug submission form -- the "Group:" field only accepts
0.4.X.]

The mail gateway mailgw.py invokes db.user.filter()
with empty lists
as 'group' and 'sort' arguments. In filter(), however,
the lists are
indexed without checking for elements, and so the mail
gateway
dies.

It works for me with the following patch:

*** rdbms_common.py.orig        Wed Oct  2 07:54:08 2002
--- rdbms_common.py     Fri Oct  4 17:27:25 2002
***************
*** 1796,1802 ****
          # can modify it...)
          orderby = []
          ordercols = []
!         if group[0] is not None and group[1] is not None:
              if group[0] != '-':
                  orderby.append('_'+group[1])
                  ordercols.append('_'+group[1])
--- 1796,1802 ----
          # can modify it...)
          orderby = []
          ordercols = []
!         if group and group[0] is not None and
group[1] is not None:
              if group[0] != '-':
                  orderby.append('_'+group[1])
                  ordercols.append('_'+group[1])
***************
*** 1806,1812 ****
  
          # now add in the sorting
          group = ''
!         if sort[0] is not None and sort[1] is not None:
              direction, colname = sort
              if direction != '-':
                  if colname == 'id':
--- 1806,1812 ----
  
          # now add in the sorting
          group = ''
!         if sort and sort[0] is not None and sort[1]
is not None:
              direction, colname = sort
              if direction != '-':
                  if colname == 'id':
msg400 Author: [hidden] (richard) Date: 2002-10-07 00:50
Logged In: YES 
user_id=6405

Hurm, API revisions :( 
Fixed in CVS now, thanks. 
 
History
Date User Action Args
2002-10-04 15:49:00lannertcreate