Issue 621248
Created on 2002-10-10 11:11 by ber, last changed 2003-08-10 10:41 by jlgijsbers.
msg424 |
Author: [hidden] (ber) |
Date: 2002-10-10 11:11 |
|
There should be a (documented) way to delete individual
queries.
It seems possible to edit queries when you give the
same name
in the query form. Maybe that should be documented, too. :)
|
msg425 |
Author: [hidden] (richard) |
Date: 2002-10-10 11:15 |
|
Logged In: YES
user_id=6405
I thought the edit behaviour was obvious... the query edit form doesn't
fill out the fields correctly though - a known bug.
Deleting of queries will be enabled the same time I enable retiring of
everything else.
|
msg426 |
Author: [hidden] (richard) |
Date: 2002-11-06 09:43 |
|
Logged In: YES
user_id=6405
Queries are deletable now.
Query editing is going to be a pain... deferring...
|
msg427 |
Author: [hidden] (jlgijsbers) |
Date: 2003-06-06 15:11 |
|
Logged In: YES
user_id=469548
Well, maybe there is a way that isn't much of a pain and
mostly leaves the current design alone. To achieve this, we'd
need to implement filling in the form fields in the templates.
However, this is inconsistent with the rest of roundup, which
uses field() and other methods of HTMLProperty to achieve
this. It also means there would be a lot of duplication in the
issue.search template. The latter can be adressed by using
METAL macro's, but to get the level of flexibility required we'd
have to use tal:define to pass variables into the macro's,
which
is ugly. Still, it works and is easy to implement.
Another option would be to use the methods of
HTMLProperty, but this would require some changes to the
design:
Instead of representing the query properties as an
attribute 'url', use an instance of the Issue class that doesn't
show up when using find(), list() or lookup() just like a retired
node, and insert a 'filter' Link attribute to that node in the
Query class, so the templates could access the methods of
HTMLProperty using 'query/filter/priority' for example.
Unfortunately, a Link property can only link to one class, so
extending the above design for searching multiple classes
wouldn't be easy. Also, that some nodes in the Issue class
wouldn't really be Issues, but just filters for searching Issues
seems ugly.
As using macro's and keeping the current design was a lot
easier and didn't require major changes like the design above,
I decided to go for the macro's (query-editing.diff):
- Totally reworked the issue.search template using new
macros in 'page' and updated the category example in
customization.txt to reflect these changes. I've tried to keep
issue.search as simple as possible, while hiding the details of
query editing in the macros.
- Changed HTMLRequest.updateFromUrl to set request.form
to be a cgi.FieldStorage instead of a dictionary, to ensure
request.form.getvalue() is always available.
|
msg428 |
Author: [hidden] (jlgijsbers) |
Date: 2003-06-06 15:13 |
|
Logged In: YES
user_id=469548
Patch available at http://sourceforge.net/tracker/index.php?
func=detail&aid=750140&group_id=31577&atid=402790.
|
msg429 |
Author: [hidden] (richard) |
Date: 2003-06-24 02:06 |
|
Logged In: YES
user_id=6405
I've applied the patches to CVS, but the query edit form doesn't
appear to be filled in correctly.
|
msg430 |
Author: [hidden] (jlgijsbers) |
Date: 2003-06-25 12:08 |
|
Logged In: YES
user_id=469548
I could have made a mistake in creating the patches. I'll get
HEAD and create new ones.
|
msg431 |
Author: [hidden] (richard) |
Date: 2003-06-27 00:40 |
|
Logged In: YES
user_id=6405
Or I might've stuffed up the patching (there weren't any
conflicts though...)
Let me know if you'd rather just have CVS access.
|
msg432 |
Author: [hidden] (jlgijsbers) |
Date: 2003-07-01 09:53 |
|
Logged In: YES
user_id=469548
No, I messed up the diff. This patch (available at
http://sourceforge.net/tracker/index.php?
func=detail&aid=750140&group_id=31577&atid=402790 again)
includes all the changes for query-editing, but not
renaming 'url' to 'query_string'.
Unfortunately, CVS access wouldn't be very useful for me
yet. My workstation doesn't have internet access yet, so I
can only get on the internet using other computers without
development tools. I'll ask for CVS access when I have more
to contribute and have internet access on my workstation.
|
msg433 |
Author: [hidden] (jlgijsbers) |
Date: 2003-08-10 10:41 |
|
Logged In: YES
user_id=469548
Fixed in CVS.
|
|
Date |
User |
Action |
Args |
2002-10-10 11:11:31 | ber | create | |
|