Roundup Tracker - Issues

Issue 625808

classification
MESSAGES_TO_AUTHOR support value new
Type: rfe Severity: normal
Components: Interface Versions:
process
Status: closed invalid
:
: richard : richard, rouilj
Priority: normal :

Created on 2002-10-20 04:00 by anonymous, last changed 2003-02-24 03:05 by rouilj.

Messages
msg3087 Author: [hidden] (anonymous) Date: 2002-10-20 04:00
Make MESSAGES_TO_AUTHOR in config.py 
be tri-valued 
like the *TO_NOSY variables in config.py.

If the value of 
MESSAGES_TO_AUTHOR is set to 'new'
act as though the 
setting was no except when a new issue is created. When a new 
issue is created, respond with a welcome/acknowledgement 
message to the author of the issue. This will:

  provide 
feedback to the author that the issue has
    been 
received.

  provide a mechanism for the author to add 
additional
    information to the issue before anybody else
    
responds to it.

This allows the initial message to be acked 
to the author while preventing subsequent emails from being sent 
back to their authors.
msg3088 Author: [hidden] (richard) Date: 2002-10-20 22:25
Logged In: YES 
user_id=6405

This is a bit of an edge case, I think. For now, you can just set up your 
own reactor that does the job. You can do this by copying the 
nosyreaction code and only firing on  "create" events. Please discuss 
on the roundup-users mailing list if you have any further questions.  
 
I'll consider adding the "new" option... 
 
msg3089 Author: [hidden] (anonymous) Date: 2003-02-08 04:30
Logged In: NO 

Here is the patch to the cvs HEAD as of 16:00 eastern time today to add 
the ability to send email to the autor of the message only if it is a new 
message.

The advantage of this is that the author:

   knows 
positively that the issue has been received if he
       sends it by 
email

  eases email interaction with the issue regardless of how 

     the issue was submitted (web or email)

Index: 
roundup/roundupdb.py
===================================================================
RCS 
file: /cvsroot/roundup/roundup/roundupdb.py,v
retrieving revision 
1.3
diff -u -r1.3 roundupdb.py
--- roundup/roundupdb.py        2003/02/08 
02:37:43     1.3
+++ roundup/roundupdb.py        2003/02/08 
03:42:48
@@ -130,9 +130,12 @@
 
         # possibly send the 
message to the author, as long as they aren't
         # anonymous
-        if 
(self.db.config.MESSAGES_TO_AUTHOR == 'yes' and
-                
users.get(authid, 'username') != 'anonymous'):
-            
sendto.append(authid)
+        if (users.get(authid, 'username') != 
'anonymous'):
+            if (self.db.config.MESSAGES_TO_AUTHOR == 
'yes'):
+                sendto.append(authid)
+            elif 
(self.db.config.MESSAGES_TO_AUTHOR == 'new' and
+                  not 
oldvalues): # send only if new message
+               
sendto.append(authid)
         r[authid] = 1
 
         # now deal with cc 
people.
msg3090 Author: [hidden] (rouilj) Date: 2003-02-08 06:01
Logged In: YES 
user_id=707416

Actually use this patch instead. It allows a reactor to make
multiple 
nosy calls without duplicating email to the author. It
also updated the 
recipient list to show that the author
received a copy.

Index: 
roundupdb.py
===================================================================
RCS 
file: /cvsroot/roundup/roundup/roundupdb.py,v
retrieving revision 
1.4
diff -u -r1.4 roundupdb.py
--- roundupdb.py        2003/02/08 04:13:50     
1.4
+++ roundupdb.py        2003/02/08 05:48:57
@@ -130,12 
+130,15 @@
 
         # possibly send the message to the author, as long 
as they aren't
         # anonymous
-        if (users.get(authid, 'username') != 
'anonymous'):
+        if (users.get(authid, 'username') != 'anonymous' 
and
+            not r.has_key(authid)):
             if 
(self.db.config.MESSAGES_TO_AUTHOR == 'yes'):
                 
sendto.append(authid)
+                recipients.append(authid)
             elif 
(self.db.config.MESSAGES_TO_AUTHOR == 'new' and
                   not 
oldvalues): # send only if new message
                
sendto.append(authid)
+                recipients.append(authid)
         r[authid] = 
1
 
         # now deal with cc people.





-- rouilj
msg3091 Author: [hidden] (rouilj) Date: 2003-02-24 03:05
Logged In: YES 
user_id=707416

Richard:

What is the status of this patch? Are you willing to 
accept it?

-- rouilj
History
Date User Action Args
2002-10-20 04:00:27anonymouscreate