Roundup Tracker - Issues

Issue 891798

classification
User queries name collisions not handled properly
Type: Severity: normal
Components: Web interface Versions:
process
Status: closed fixed
:
: jlgijsbers : bosseb, jlgijsbers, richard, rouilj
Priority: normal :

Created on 2004-02-06 13:58 by bosseb, last changed 2004-03-26 04:51 by richard.

Messages
msg1091 Author: [hidden] (bosseb) Date: 2004-02-06 13:58
If a user does a search and enters a name for it the 
query should then appear in his list of queries.

But we found that if user A has created a query for 
himself with name "SIGMA" and then user B creates a 
different query and names it "SIGMA" too (happens if 
this is a product name for instance), then the query 
does NOT appear on the list of queries for user B.

However the query "SIGMA" for user A gets *updated* 
with the conditions user B entered, thus destroying the 
careful layout user A had created....

We feel that queries should be private to each user and 
inaccessible by others, or else all queries should be 
available to all users (=public). Either way, but not the 
way it is implemented now.
msg1092 Author: [hidden] (richard) Date: 2004-02-06 22:43
Logged In: YES 
user_id=6405

User queries are a feature that I've never really bought into (as I 
personally have no need for it - I am capable of bookmarking 
URLs ;)

This needs a champion...
msg1093 Author: [hidden] (jlgijsbers) Date: 2004-02-07 16:17
Logged In: YES 
user_id=469548

I'll take it. I know the code anyway.
msg1094 Author: [hidden] (richard) Date: 2004-02-07 22:48
Logged In: YES 
user_id=6405

Thanks. It's important that the user interface be made far more 
obvious, but also that queries *may* be shared amongst all 
users. Perhaps the search page could have a list of existing 
queries on it?
msg1095 Author: [hidden] (jlgijsbers) Date: 2004-02-09 10:01
Logged In: YES 
user_id=469548

Sounds about right. How about making all queries public (on
a page linked from the search form), so that anyone can add
it to his queries Multilink, but letting only the one who
created the query edit it? Others can create a new query
based on the query by someone else, but not edit it.
msg1096 Author: [hidden] (bosseb) Date: 2004-02-09 10:41
Logged In: YES 
user_id=828036

That idea will combine the suggestions from myself and 
Richard, I guess. Sounds fine to me.
The GUI design needs to handle the case where there are 
many "canned" queries though, so after reaching the Search 
page there could be a "Load existing" link that brings up a 
selection page listing all queries by name and owner.
Then upon selection of one the Search page is populated 
with the selected query spec and the name is entered into 
the name box *if* the owner is the current user. Otherwise 
the name is just given as info somewhere (non-editable).
So the owner can the easily modify the query.
One problem that might pop up down the road:
If a user creates a lot of queries his sidebar might get too 
crowded with all of the query names on top. Could it be 
possible to show all the user queries in a combobox in the 
sidebar and below it a link to the last used queries?
Maybe keeping a last used list with direct links to a fixed max 
like 5 or so, and if the total is above then display the combo?
Just some ideas....
msg1097 Author: [hidden] (bosseb) Date: 2004-02-09 13:31
Logged In: YES 
user_id=828036

One additional item if work is going to be done concerning 
queries:
It would be good to show the name of the query in the title 
of the result page so it would read:
List of issues (Query: MyFineQuery)
or similar.
Right now it is not possible to see for sure what caused the 
list currently on screen.
msg1098 Author: [hidden] (rouilj) Date: 2004-02-10 00:01
Logged In: YES 
user_id=707416

Actually, I can think of a couple of use cases where
searches should not be public (e.g. searches for abusing
users where the query may be viewed by the person being
searched for).

I don't have a good solution to the key problem though.
Maybe we can use a unique key field formed from
the user who created the query and the name of the
query?

I think public and private searches should do most  of the
trick without trying to graft an entire ACL system onto
queries.

-- rouilj
msg1099 Author: [hidden] (richard) Date: 2004-03-26 04:51
Logged In: YES 
user_id=6405

Done. Geez I'm good to you guys :) 
 
See the upgrading doc and user guide in 0.7 for info about 
how to migrate to the new query mechanisms. 
 
History
Date User Action Args
2004-02-06 13:58:36bossebcreate