Roundup Tracker - Issues

Issue 904064

classification
traceback from demo.py
Type: Severity: normal
Components: Database Versions:
process
Status: closed fixed
:
: richard : harripasanen, richard
Priority: normal :

Created on 2004-02-25 08:26 by harripasanen, last changed 2004-02-25 22:46 by richard.

Messages
msg1123 Author: [hidden] (harripasanen) Date: 2004-02-25 08:26
How to repeat: 
 
1. fire up the demo: 
$ python demo.py 
2. Connect to demo at http://localhost:8917/demo/ and 
Enter "msg1" to the textfield under the "Show Issue" button, and 
click on the "Show Issue" button. 
 
The following traceback appears: 
 
 
KeyError: There is no class called "issuemsg" 
 
A problem occurred while running a Python script. Here is the 
sequence of function calls leading up to the error, with the most 
recent (innermost) call first. The exception attributes are: 
      __doc__ = 'Mapping key not found.'  
      __getitem__ = <bound method KeyError.__getitem__ of 
<exceptions.KeyError instance>>  
      __init__ = <bound method KeyError.__init__ of 
<exceptions.KeyError instance>>  
      __module__ = 'exceptions'  
      __str__ = <bound method KeyError.__str__ of 
<exceptions.KeyError instance>>  
      args = ('There is no class called "issuemsg"',) 
 
 
 
/home/harri/downloads/roundup-0.6.6/roundup/backends/back_anydbm.py 
in getclass(self=<back_anydbm instance at 82ffd94>, 
classname='issuemsg') 
 
  144             return self.classes[classname] 
   145         except KeyError: 
  
 
  146             raise KeyError, 'There is no class called 
"%s"'%classname 
  
 
      global KeyError = undefined, classname = 'issuemsg' 
   147  
   148     # 
  
 
 
/home/harri/downloads/roundup-0.6.6/roundup/cgi/client.py in 
determine_context(self=<_roundup_tracker_1.interfaces.Client 
instance>, dre=<_sre.SRE_Pattern object>) 
 
  
msg1124 Author: [hidden] (richard) Date: 2004-02-25 09:18
Logged In: YES 
user_id=6405

The Javascript for that box isn't so smart - it assumes you've 
entered an issue ID. Try just an ID. 
msg1125 Author: [hidden] (harripasanen) Date: 2004-02-25 09:44
Logged In: YES 
user_id=77088

Well, I though I had entered an ID, as I saw some msg1 column 
header somewhere (I did not realise then that there is a separation 
between a message and an issue). 
 
However,  my point was more on what is the feedback a clueless user 
gets when he inadvertedly enters bad input. 
 
I'd think a more approriate behaviour would be to harden the input 
checking a bit, so that non valid ID would give a message 'Issue not 
found', or something along those lines. 
 
Regards, 
 
Harri 
msg1126 Author: [hidden] (richard) Date: 2004-02-25 22:46
Logged In: YES 
user_id=6405

I am looking into making the Javascript a little smarter. 
msg1127 Author: [hidden] (richard) Date: 2004-02-25 23:30
Logged In: YES 
user_id=6405

Thanks for persisting, I've now made the user feedback 
much clearer. Patched in maint-0-6 and HEAD. 
 
History
Date User Action Args
2004-02-25 08:26:23harripasanencreate