Roundup Tracker - Issues

Issue 973946

classification
broken roundup-server -g
Type: Severity: normal
Components: Command-line interface Versions:
process
Status: closed fixed
:
: richard : a1s, richard
Priority: normal :

Created on 2004-06-16 15:28 by a1s, last changed 2004-06-21 04:33 by richard.

Messages
msg1314 Author: [hidden] (a1s) Date: 2004-06-16 15:28
'-g' option of the roundup-server script is broken in
two ways:

first, it ignores it's argument.  instead, gid is set
to the primary group of the server user (set by
constant in the server script or by '-u' command line
option).

second, it assumes that setgid() is allowed to users of
group 0.  that's not so.  from setgid() manual: "The
setgid() function is permitted if the specified ID is
equal to the real group ID or the effective group ID of
the process, or if the effective user ID is that of the
super user."  that is, we must check for zero uid, not
for zero gid.

the attached patch should fix both these problems.

warning: the patch is not tested.
msg1315 Author: [hidden] (richard) Date: 2004-06-21 04:33
Logged In: YES 
user_id=6405

Fixed, thanks. 
History
Date User Action Args
2004-06-16 15:28:59a1screate