Roundup Tracker - Issues

Issue 987933

classification
Error when send out an email with None as DB message ID
Type: Severity: normal
Components: Database Versions:
process
Status: closed fixed
:
: richard : marlonvdb, richard
Priority: normal :

Created on 2004-07-09 12:50 by marlonvdb, last changed 2004-07-09 12:50 by marlonvdb.

Messages
msg1350 Author: [hidden] (marlonvdb) Date: 2004-07-09 12:50
RoundUp version: 0.7.5
File: roundupdb.py
Error: Edit Error: no such msg node None
Error line: 223 -> messages.set(msgid, 
messageid=messageid)

Comment:
The document string of 
method 'IssueClass.nosymessage' indicates that 
a 'System Message' mail is send to the CC list if 
the 'msgid' is None. But 
method 'IssueClass.send_message' will raise the above 
error at the line 223 (see above), because the method 
creates a new message id and tries to store it in the 
database for node 'msgid' which is None.
msg1351 Author: [hidden] (marlonvdb) Date: 2004-07-09 13:14
Logged In: YES 
user_id=1080231

A solution could be:

Line 217:
    if not messageid:
Change into:
    if msgid is not None and not messageid:

Lines 255-256:
    # add the content
    m.appen(messages.safeget(msgid, 'content', ''))
Change into:
    # add the content
    if msgid is not None:
        m.appen(messages.safeget(msgid, 'content', ''))
msg1352 Author: [hidden] (marlonvdb) Date: 2004-07-09 13:14
Logged In: YES 
user_id=1080231

A solution could be:

Line 217:
    if not messageid:
Change into:
    if msgid is not None and not messageid:

Lines 255-256:
    # add the content
    m.appen(messages.safeget(msgid, 'content', ''))
Change into:
    # add the content
    if msgid is not None:
        m.appen(messages.safeget(msgid, 'content', ''))
History
Date User Action Args
2004-07-09 12:50:33marlonvdbcreate