Roundup Tracker - Issues

Issue 994750

classification
nosy_message() doesn't work with msgid==None
Type: Severity: normal
Components: Database Versions:
process
Status: closed fixed
:
: richard : richard, syrk
Priority: normal :

Created on 2004-07-20 19:29 by syrk, last changed 2004-10-08 05:51 by richard.

Messages
msg1384 Author: [hidden] (syrk) Date: 2004-07-20 19:29
This was changed to work in revision 1.93 and 
subsequently advertised.  However, as far as i can tell, 1.
94 removes such functionality.

This is most unfortunate ;-)

Haven't checked whether send_message()'s changes 
suffered the same fate.
msg1385 Author: [hidden] (richard) Date: 2004-07-21 01:12
Logged In: YES 
user_id=6405

I believe this is fixed in roundupdb.py version 1.112 (1.108.2.1 in 
the maint-0-7 branch) 
msg1386 Author: [hidden] (syrk) Date: 2004-07-21 16:31
Logged In: YES 
user_id=38283

No it's not.
Well, nosy_message() is okay, but the 4th and 5th lines of 
send_message() assume msgid is not None.  i guess the 
problem is that safeget() isn't nearly as safe as its name 
implies, and it needs a valid msgid.

(i'm quite happy to test anything you come up with.  again, i 
think that 1.94 broke too much.)
msg1387 Author: [hidden] (richard) Date: 2004-07-22 00:46
Logged In: YES 
user_id=6405

I didn't like safeget() when it was added, and I still don't like it. Which 
backend are you using?
msg1388 Author: [hidden] (anonymous) Date: 2004-07-22 05:27
Logged In: NO 

SQLite
msg1389 Author: [hidden] (richard) Date: 2004-10-08 05:51
Logged In: YES 
user_id=6405

I have remove safeget from the API. 
 
I have also fixed send_ and nosymessage() so they handle 
msgid=None. 
 
All in CVS HEAD. Don't want to change 0.7 API at this stage, and 
don't want to try to fix stuff to use safeget() :( 
History
Date User Action Args
2004-07-20 19:29:59syrkcreate