Message1086
Take a bug with nosy's or topic's listed and click on
the corresponding (list)
link. In the help dialog that opens, the lists are
implemented in Javascript.
The JS code for this includes a browser check,
which tests for IE, and then does:
// add the pop() and push() method to Array
prototype for old IE browser
if (bName() == 1 && bVer() >= 5.5);
else {
Array.prototype.pop = pop;
Array.prototype.push = push;
}
This breaks in Konqueror due to a konqueror bug
("pop" would then appear when enumerating an
array), which is how I got to look at this code.
We'll fix it, but I'm also filing a bug report here
because hardcoded browser checks are always
wrong, they do not take into account all the other
browsers out there.
Better check if the browser knows pop, and add it if
not, without hardcoded check for IE>=5.5
This could be done simply with
if (!Array.prototype.pop) { Array.prototype.pop =
pop; }
if (!Array.prototype.push) { Array.prototype.push =
push; }
|
|
Date |
User |
Action |
Args |
2009-02-03 14:20:35 | admin | link | issue877504 messages |
2009-02-03 14:20:35 | admin | create | |
|