Roundup Tracker - Issues

Message4029

Author kowey
Recipients kowey
Date 2010-02-22.14:39:36
Message-id <1266849577.38.0.504612533138.issue2550640@psf.upfronthosting.co.za>
In-reply-to
We just noticed this on http://bugs.darcs.net/issue1751 (roundup 1.4.4
via Debian Lenny).

Digging around a bit, I noticed this roundupdb.py:

            if not inreplyto:
                # Default the reply to the first message
                msgs = self.get(nodeid, 'messages')
                # Assume messages are sorted by increasing message
number here
                if msgs[0] != nodeid:
                    inreplyto = messages.get(msgs[0], 'messageid')
                    if inreplyto:
                        writer.addheader('In-Reply-To', inreplyto)

Could that be the culprit?  It seems like the very first message in an
issue gets this, whereas subsequent messages have correct-looking
in-reply-to headers.

Is it actually bad for messages to be replies to themselves?  Why not
just not have an In-Reply-To header for just cases?
History
Date User Action Args
2010-02-22 14:39:37koweysetrecipients: + kowey
2010-02-22 14:39:37koweysetmessageid: <1266849577.38.0.504612533138.issue2550640@psf.upfronthosting.co.za>
2010-02-22 14:39:37koweylinkissue2550640 messages
2010-02-22 14:39:36koweycreate