Roundup Tracker - Issues

Message4190

Author jerrykan
Recipients ThomasAH, ber, jerrykan
Date 2010-11-01.01:46:57
Message-id <1288576019.63.0.824324800386.issue2550678@psf.upfronthosting.co.za>
In-reply-to
I was having a bit of a think about this on the weekend and came the the
conclusion that pagesize=0 would also probably be a better fit.

I have attached a second page that reflects this change.


I have also made a couple of changes to the Batch class. 'self.size' was
being set to the 'pagesize' specified and not being used again anywhere.
'self._size' was being set to the actual size being calculated, which
meant that the previous and next links where using a hard-coded
'pagesize=##' in the url (when the actual size may have changed in the
mean time).

I have removed 'self._size', and set 'self.size' to be assigned the
'pagesize' value. The means the the correct 'pagesize=##' will be set
(even if it is 0). One issue might be if someone is using 'batch/size'
in their template for some reason. Maybe they should use 'batch/length'
instead.
History
Date User Action Args
2010-11-01 01:46:59jerrykansetmessageid: <1288576019.63.0.824324800386.issue2550678@psf.upfronthosting.co.za>
2010-11-01 01:46:59jerrykansetrecipients: + jerrykan, ber, ThomasAH
2010-11-01 01:46:59jerrykanlinkissue2550678 messages
2010-11-01 01:46:58jerrykancreate