Message4372
The pagesize=0 component of the patch works as expected.
Regarding the replacement of the "_size" with "size", I couldn't find a way to reproduce different behaviors before and after applying the path. That said, I'll note that:
- I didn't notice any breakage because of this change and all tests pass.
- But I couldn't find a way to test the effect of this specific component in the patch.
John:
Since there aren't any unit-tests for this code, can you provide a series of steps that I can follow in the demo instance to reproduce an issue that is fixed by the "_size" component of your patch?
If the above is not easy, then I would suggest the following:
If the "_size" to "size" change is not needed for the "pagesize=0" component to work, break these into two separate patches, so that at least the "pagesize=0" component, which is a very useful feature, can be merged into the trunk. |
|
Date |
User |
Action |
Args |
2011-08-11 22:38:48 | satchit | set | recipients:
+ satchit, ber, jerrykan, ThomasAH |
2011-08-11 22:38:48 | satchit | link | issue2550678 messages |
2011-08-11 22:38:47 | satchit | create | |
|