Roundup Tracker - Issues

Message5725

Author rouilj
Recipients ber, r.david.murray, rouilj, schlatterbeck
Date 2016-07-03.04:51:34
Message-id <1467521494.98.0.961155660161.issue2550831@psf.upfronthosting.co.za>
In-reply-to
I finally have this patch in the pipeline.

I have chnaged the table layout a bit. I added section heads in the
table so it looks like (hope the ascii art works):

  Query     Include in "Your Queries"   Edit    Private to you?          
  *Queries I created*
  pede      include                     edit         yes          [Delete]
  edit      leave out                   edit         yes          [Delete]
  *Queries others created*
  clearcase leave out                   [not yours to edit]
  demo 1    include                     [not yours to edit]
  *My retired queries*
  alpha 2   [query is retired]                                    [Restore]
  [Save Selection]

I also added Restore action in cgi/Actions.py and added it to
client.py. To alow the user to restore queries, schema.py needs to
have:

  p = db.security.addPermission(name='Restore', klass='query',
check=edit_query,
      description="User is allowed to restore their queries")
  db.security.addPermissionToRole('User', p)

added to it.

Also R David's patch to LinkHTMLProperty looks like it solved the
filter issue. Note that filter() never returns retired issues, so I was
able to replace the tal:condition in all your tal:block and push it to
the filter using:

  <tr tal:define="queries python:db.query.filter(filterspec={'creator':
uid})"
    tal:repeat="query queries">
   <tal:block>

and

  <tr tal:define="queries
		python:db.query.filter(filterspec={'private_for': None})"
     tal:repeat="query queries">
   <tal:block>

This should help performance.


Hopefully I'll have it committed by Monday so people can kick the tires
on it.
History
Date User Action Args
2016-07-03 04:51:34rouiljsetmessageid: <1467521494.98.0.961155660161.issue2550831@psf.upfronthosting.co.za>
2016-07-03 04:51:34rouiljsetrecipients: + rouilj, schlatterbeck, ber, r.david.murray
2016-07-03 04:51:34rouiljlinkissue2550831 messages
2016-07-03 04:51:34rouiljcreate