Roundup Tracker - Issues

Message5819

Author rouilj
Recipients ThomasAH, ber, jerome, ollydbg, pefu, rouilj, yanqian
Date 2016-07-10.19:05:30
Message-id <1468177530.6.0.159181744152.issue2550788@psf.upfronthosting.co.za>
In-reply-to
If we want to add this to the core it looks like I need to:

change the 

from mmseg.search import seg_txt_search,seg_txt_2_dict

to

try:
  MissingMmseg=False
  from mmseg.search import seg_txt_search,seg_txt_2_dict
except ImportError:
  MissingMmseg=True

and then wrap the second section in if not MissingMmseg

Then add to installation.doc the package info and why people
would want it.

Does anybody see anything else I would need to incorporate this patch?

Does anybody believe this patch should not go into core?

Note I have no idea how to write a test for it and the test is
conditional on having and not having the mmseg module.

-- rouilj
History
Date User Action Args
2016-07-10 19:05:30rouiljsetmessageid: <1468177530.6.0.159181744152.issue2550788@psf.upfronthosting.co.za>
2016-07-10 19:05:30rouiljsetrecipients: + rouilj, ber, pefu, ThomasAH, jerome, yanqian, ollydbg
2016-07-10 19:05:30rouiljlinkissue2550788 messages
2016-07-10 19:05:30rouiljcreate