Roundup Tracker - Issues

Message5860

Author rouilj
Recipients bruceguenter, richard, rouilj
Date 2016-07-15.23:39:35
Message-id <1468625976.05.0.915827275599.issue1074059@psf.upfronthosting.co.za>
In-reply-to
Looks like this was patched:

diff -r 8d5c95c33447 -r 7c8d2e9a0566 roundup/cgi/templating.py
--- a/roundup/cgi/templating.py Fri May 14 22:43:33 2004 +0000
+++ b/roundup/cgi/templating.py Sat May 15 03:53:43 2004 +0000
@@ -671,7 +671,7 @@
         Also sneak in the lastactivity and action hidden elements.
         """
         return self.input(type="hidden", name="@lastactivity",
-            value=self.activity) + '\n' + \
+            value=self.activity.local(0)) + '\n' + \
             self.input(type="hidden", name="@action", value="edit") +
'\n' + 
             self.input(type="submit", name="submit", value=label)

Before this patch, the lastNodeActivity was calculated using the
.local(0) value (setting it behind by 22 seconds) while the value for
@lastactivity in the templating class was not localized. So the same
time with two different corrections could have produced the problem.

In any case, I tested using:

  TZ=right/EST5EDT ./demo.py

and the values provided by the lastuseractivity value from templating
and the lastNodeActivity value have the same value and
roundup/cgi/actions.py:EditItemAction::detectCollision()
passes allowing me to edit the properties on the issue.

Closing as works for me.

(Note the timeline for this issue and the patch is all screwed up. The
patch went in before the 0.7.9 release and before this ticket was
opened. Maybe a problem with SF to this tracker conversion?)
History
Date User Action Args
2016-07-15 23:39:36rouiljsetmessageid: <1468625976.05.0.915827275599.issue1074059@psf.upfronthosting.co.za>
2016-07-15 23:39:36rouiljsetrecipients: + rouilj, richard, bruceguenter
2016-07-15 23:39:36rouiljlinkissue1074059 messages
2016-07-15 23:39:35rouiljcreate